Bugzilla – Attachment 167060 Details for
Bug 35771
Unselecting titles when making multi-hold does not have any effect
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35771: Unselecting titles when making multi-hold
Bug-35771-Unselecting-titles-when-making-multi-hol.patch (text/plain), 3.47 KB, created by
David Nind
on 2024-05-23 05:11:46 UTC
(
hide
)
Description:
Bug 35771: Unselecting titles when making multi-hold
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-05-23 05:11:46 UTC
Size:
3.47 KB
patch
obsolete
>From 738fb3748c76602bc3622d613809762d1b1aaed3 Mon Sep 17 00:00:00 2001 >From: Katariina Pohto <trainee@koha-suomi.fi> >Date: Tue, 21 May 2024 16:33:52 +0300 >Subject: [PATCH] Bug 35771: Unselecting titles when making multi-hold > >When placing a hold on multiple biblios Place Holds page (request.pl) has checkboxes for unselecting some of the listed biblios. >Removing the checkmark does not actually unselect the biblio. Clicking the Place holds button will place a hold for all the biblios on page that can be reserved. >If unchecked biblio does not have a pickup location, it will get past form validation and cause an error. > >Test plan: >1. Select several biblios and choose Place hold >2. Choose a patron >3. Select a pickup location for all biblios and unselect one of the checkmarks >4. Place holds and note that even the deselected holds was placed. >5. Repeat steps 1-2. >6. Leave pickup locations empty and try to place the holds. >7. Note alert: "Please make sure all selected titles have a pickup location set" >8. Uncheck one of the biblios and add pickup locations to the checked biblios. >9. Try to place the holds and note that there is no alert, and you get an error 500. >10. Apply patch. >11. Repeat steps 1,2,8 and place holds. >12. Note that there is no error 500, and while all the biblios are shown on page, only the checked biblios have a new hold placed on them. > >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >index 335aa6355f..52bd7725ed 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt >@@ -1057,7 +1057,6 @@ > [% FOREACH biblioloo IN biblioloop %] > <input type="hidden" name="biblionumber" id="biblionumber" value="[% biblioloo.biblionumber | html %]"/> > [% UNLESS biblioloo.none_avail %] >- <input type="hidden" name="holdable_bibs" id="holdable_bibs" value="[% biblioloo.biblionumber | html %]"/> > <input type="hidden" name="title_[% biblioloo.biblionumber | html %]" value="[% biblioloo.title | html %]"/> > <input type="hidden" name="rank_[% biblioloo.biblionumber | html %]" value="[% biblioloo.rank | html %]"/> > [% END %] >@@ -1120,7 +1119,7 @@ > [% END %] > <td> > [% UNLESS ( biblioloo.warn ) %] >- <input class="multi_hold_item_checkbox" type="checkbox" checked="checked" title="[% biblioloo.biblionumber | html %]"/> >+ <input id="holdable_bibs" name="holdable_bibs" class="multi_hold_item_checkbox" type="checkbox" checked="checked" title="[% biblioloo.biblionumber | html %]" value="[% biblioloo.biblionumber | html %]"/> > [% END %] > </td> > <td> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35771
:
160810
|
160811
|
166780
|
166977
|
167060
|
171259