Attachment 167080 Details for Bug 36935 – Bug 36935: Remove warning if file parsing is successful

[patch] Bug 36935: Remove warning if file parsing is successful

Bug-36935-Remove-warning-if-file-parsing-is-succes.patch (text/plain), 1.11 KB, created by David Nind on 2024-05-23 09:00:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-05-23 09:00:04 UTC

Size: 1.11 KB

patch

obsolete

>From af290ff1636c20465ea4acb1fd39ace7311188cd Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Thu, 23 May 2024 08:32:22 +0000
>Subject: [PATCH] Bug 36935: Remove warning if file parsing is successful
>
>This patch removes the logged warning if a file parse is successful.
>
>Test plan:
>1) prove t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t
>2) The output will have a logged message - 'EOF - End of data in parsing input stream'
>3) Apply patch
>4) Repeat step 1
>5) The warning will be gone
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> Koha/BackgroundJob/ImportKBARTFile.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/Koha/BackgroundJob/ImportKBARTFile.pm b/Koha/BackgroundJob/ImportKBARTFile.pm
>index d17dcf502f..16861570b7 100644
>--- a/Koha/BackgroundJob/ImportKBARTFile.pm
>+++ b/Koha/BackgroundJob/ImportKBARTFile.pm
>@@ -244,7 +244,7 @@ sub read_file {
> 
>     my ( $cde, $str, $pos ) = $csv->error_diag();
>     my $error = $cde ? "$cde, $str, $pos" : "";
>-    warn $error if $error;
>+    warn $error if $error && $cde ne '2012';
> 
>     close($fh);
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36935: 167078 | 167080 | 167088 | 167089 | 167099 | 167130 | 167131 | 167132 | 168326 | 168327 | 168328