Bugzilla – Attachment 167081 Details for
Bug 36939
Serials.t generates a warning
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36939: Remove a warning from Serials.t
Bug-36939-Remove-a-warning-from-Serialst.patch (text/plain), 1.07 KB, created by
David Nind
on 2024-05-23 09:03:17 UTC
(
hide
)
Description:
Bug 36939: Remove a warning from Serials.t
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-05-23 09:03:17 UTC
Size:
1.07 KB
patch
obsolete
>From bb641f223d4ed1f0ed86e09ab15da841ef9a3a05 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 May 2024 09:50:59 +0200 >Subject: [PATCH] Bug 36939: Remove a warning from Serials.t > >t/db_dependent/Serials.t .. 2/57 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Serials.pm line 2029. > >Signed-off-by: David Nind <david@davidnind.com> >--- > C4/Serials.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Serials.pm b/C4/Serials.pm >index c3d33cadf5..79a3a70dbd 100644 >--- a/C4/Serials.pm >+++ b/C4/Serials.pm >@@ -2026,8 +2026,8 @@ sub addroutingmember { > my $sth = $dbh->prepare( "SELECT max(ranking) rank FROM subscriptionroutinglist WHERE subscriptionid = ?" ); > $sth->execute($subscriptionid); > while ( my $line = $sth->fetchrow_hashref ) { >- if ( $line->{'rank'} > 0 ) { >- $rank = $line->{'rank'} + 1; >+ if ( defined $line->{rank} && $line->{rank} > 0 ) { >+ $rank = $line->{rank} + 1; > } else { > $rank = 1; > } >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36939
:
167076
|
167081
|
167156