Attachment 167087 Details for Bug 36908 – Bug 36908: (QA follow-up) Proposed improvement to prefernce description

[patch] Bug 36908: (QA follow-up) Proposed improvement to prefernce description

Bug-36908-QA-follow-up-Proposed-improvement-to-pre.patch (text/plain), 2.64 KB, created by Martin Renvoize (ashimema) on 2024-05-23 09:39:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-05-23 09:39:03 UTC

Size: 2.64 KB

patch

obsolete

>From 6205e0ef88de4a825c44b9bcdaa1d3f6d86929d2 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 23 May 2024 10:36:55 +0100
>Subject: [PATCH] Bug 36908: (QA follow-up) Proposed improvement to prefernce
> description
>
>I found the initial addition of 'or the branch chosen at login' to the
>system preference description more misleading than the original. After
>discussion on mattermost and with training staff here at PTFS the best
>alternative we could come up with is proposed here.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/admin/preferences/admin.pref              | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>index efba78026b7..2f8a448cf19 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>@@ -91,14 +91,14 @@ Administration:
>               class: integer
>             - Adding d will specify it in days, e.g. 1d is timeout of one day.
>         -
>-            - "Require staff to log in from a computer in the IP address range specified by their library or the branch chosen at login (if any): "
>+            - "Limit the libraries staff can select at login to those where their computer's IP address is within the library's specified range or to libraries without an IP restriction: "
>             - pref: AutoLocation
>               default: 0
>               choices:
>                   1: "Yes"
>                   0: "No"
>             - <a href="/cgi-bin/koha/admin/branches.pl">Link to library administration</a>
>-            - 'Staff can only choose thier branch on login if they have "loggedinlibrary" permission. This setting will override the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=StaffLoginBranchBasedOnIP">StaffLoginBranchBasedOnIP</a> system preference. In the event of multiple branches with matching IPs, branchcode (alphabetically) will be the tie breaker.'
>+            - 'Staff can only choose thier library at login if they have the "loggedinlibrary" permission. This setting will override the <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=StaffLoginBranchBasedOnIP">StaffLoginBranchBasedOnIP</a> system preference. In the event of multiple libraries with matching IPs, branchcode (alphabetically) will be the tie breaker.'
>         -
>             - "Enable check for change in remote IP address for session security: "
>             - pref: SessionRestrictionByIP
>-- 
>2.45.1

Actions: View | Diff | Splinter Review

Attachments on bug 36908: 166966 | 166967 | 166968 | 167044 | 167045 | 167046 | 167073 | 167074 | 167075 | 167084 | 167085 | 167086 | 167087 | 167090