Bugzilla – Attachment 167124 Details for
Bug 36459
Backdating checkouts on circ/circulation.pl not working properly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36459: Do not set an empty flatpickr explicitly
Bug-36459-Do-not-set-an-empty-flatpickr-explicitly.patch (text/plain), 1.48 KB, created by
Lucas Gass (lukeg)
on 2024-05-23 16:38:45 UTC
(
hide
)
Description:
Bug 36459: Do not set an empty flatpickr explicitly
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-05-23 16:38:45 UTC
Size:
1.48 KB
patch
obsolete
>From a7a06cf01cfbcaed33988d9daea37580161fb3d7 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 23 May 2024 16:36:44 +0000 >Subject: [PATCH] Bug 36459: Do not set an empty flatpickr explicitly > >To test; >1. Go to circ/circulation.pl and check an item out to a patron. >2. Backdate it to sometime in the past using the "Specify due date (MM/DD/YYYY) : " input >3. A modal appears to "Please confirm checkout". The date is no longer populated in that field. >4. You must add the date again here. >5. APPLY PATCH >6. Try again and this time the confimration date should be set correctly. >7. Follow the test plan from Bug 18885 to make sure on site checkouts still work correctly. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index b7b4594905..aaa5543b37 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -1048,8 +1048,6 @@ > const duedatespec_fp = duedatespec._flatpickr; > if ( $("#onsite_checkout").prop('checked') ) { > duedatespec_fp.setDate("[% today_due_date_and_time | $KohaDates dateformat => 'iso', with_hours => 1 %]"); >- } else { >- duedatespec_fp.setDate(""); > } > } > } >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36459
:
167124
|
167127
|
167676
|
167684
|
167693