Bugzilla – Attachment 167128 Details for
Bug 36950
Improve placement of catalog concern banner in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36950: Improve placement of catalog concern banner in the OPAC
Bug-36950-Improve-placement-of-catalog-concern-ban.patch (text/plain), 2.46 KB, created by
David Nind
on 2024-05-23 19:59:14 UTC
(
hide
)
Description:
Bug 36950: Improve placement of catalog concern banner in the OPAC
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-05-23 19:59:14 UTC
Size:
2.46 KB
patch
obsolete
>From 653d7e0bd92f8cde70ee0b0b367d8fea1e00be81 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 23 May 2024 15:34:15 +0000 >Subject: [PATCH] Bug 36950: Improve placement of catalog concern banner in the > OPAC > >This patch changes the placement of the catalog concern banner in the >OPAC. Changing the way it is added to the DOM will prevent it from >obscuring content. > >To test, apply the patch and clear your browser cache if necessary. > >- In the staff interface, make sure the "OpacCatalogConcerns" system > preference is enabled. >- Locate a bibliographic record and view the detail page. >- Click the "Report a concern" link in the sidebar. >- Submit your concern. >- When the concern is successfully submitted and the modal closes, the > success banner ("Your concern was successfully submitted.") should > appear below the breadcrumbs menu and above the biblio view tabs > ("Normal view, "MARC view", etc.). > >Sponsored-By: Athens County Public Libraries >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/opac-tmpl/bootstrap/js/modals/catalog_concern.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/modals/catalog_concern.js b/koha-tmpl/opac-tmpl/bootstrap/js/modals/catalog_concern.js >index e9c791e9de..fd630ec01c 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/modals/catalog_concern.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/modals/catalog_concern.js >@@ -53,12 +53,12 @@ $(document).ready(function() { > $('#addConcernModal').modal('hide'); > $('#concern_body').val(''); > $('#concern_title').val(''); >- $('h1:first').before('<div class="alert alert-success">' + __("Your concern was successfully submitted.") + '</div>'); >+ $('#catalogue_detail_biblio').prepend('<div class="alert alert-success">' + __("Your concern was successfully submitted.") + '</div>'); > }, > error: function(data) { > $('#concern-submit-spinner').hide(); > $('#addConcernModal').modal('hide'); >- $('h1:first').before('<div class="alert alert-error">' + __("There was an error when submitting your concern, please contact a librarian.") + '</div>'); >+ $('#catalogue_detail_biblio').prepend('<div class="alert alert-error">' + __("There was an error when submitting your concern, please contact a librarian.") + '</div>'); > }, > contentType: "json" > }); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36950
:
167118
|
167119
|
167128
|
168323