Bugzilla – Attachment 167131 Details for
Bug 36935
BackgroundJob/ImportKBARTFile.t generates warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36935: Add a 'die' message to file parsing
Bug-36935-Add-a-die-message-to-file-parsing.patch (text/plain), 1.05 KB, created by
David Nind
on 2024-05-23 20:08:06 UTC
(
hide
)
Description:
Bug 36935: Add a 'die' message to file parsing
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-05-23 20:08:06 UTC
Size:
1.05 KB
patch
obsolete
>From f7f2f1a68c8b69ba95a1a6ca2d46b6cf73022ef4 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Thu, 23 May 2024 09:41:22 +0000 >Subject: [PATCH] Bug 36935: Add a 'die' message to file parsing > >Signed-off-by: David Nind <david@davidnind.com> >--- > Koha/BackgroundJob/ImportKBARTFile.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/BackgroundJob/ImportKBARTFile.pm b/Koha/BackgroundJob/ImportKBARTFile.pm >index b1da1bb06f..890a3c926a 100644 >--- a/Koha/BackgroundJob/ImportKBARTFile.pm >+++ b/Koha/BackgroundJob/ImportKBARTFile.pm >@@ -229,7 +229,7 @@ sub read_file { > my $delimiter = $file->{filename} =~ /\.tsv$/ ? "\t" : ","; > my $quote_char = $file->{filename} =~ /\.tsv$/ ? "\"" : "\""; > >- open my $fh, "<", \$file_content or die; >+ open my $fh, "<", \$file_content or die "Could not open file $file->{filename}: $!"; > my $csv = Text::CSV_XS->new( > { > sep_char => $delimiter, >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36935
:
167078
|
167080
|
167088
|
167089
|
167099
|
167130
|
167131
|
167132
|
168326
|
168327
|
168328