Attachment 167147 Details for Bug 36948 – Bug 36948: Resolve SIP issues in D12

[patch] Bug 36948: Resolve SIP issues in D12

Bug-36948-Resolve-SIP-issues-in-D12.patch (text/plain), 2.04 KB, created by Marcel de Rooy on 2024-05-24 08:52:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-05-24 08:52:08 UTC

Size: 2.04 KB

patch

obsolete

>From c33c760302a1b32a86b38d6c059c7eb88a249f8c Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 23 May 2024 13:56:51 +0000
>Subject: [PATCH] Bug 36948: Resolve SIP issues in D12
>Content-Type: text/plain; charset=utf-8
>
>My Koha testing docker SIP started dying repeatedly after launch. After investigation, I
>found it was a problem with logging and default ports.
>
>In D12 there is no syslog anymore, everythign uses journal. Four our purposes, lets log SIP issues
>to sip.log by default
>
>Attaching a patch to clear things up.
>
>To test:
>1 - Open KTD/D12
>2 - tail -f /var/log/koha/kohadev/*.log
>3 - On another terminal 'restart_all'
>4 - Wait a bit, notice SIP dying
>5 - Apply patch
>6 - Update SIPconfig:
>    server-params:
>    log_file='/var/log/koha/kohadev/sip.log'
>    service with port 8023:
>    port="127.0.0.1:8023/tcp"
>7 - Restart all
>8 - Confirm SIP no longer dies
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/SIP/Trapper.pm              | 4 ++++
> debian/templates/SIPconfig.xml | 4 ++--
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
>diff --git a/C4/SIP/Trapper.pm b/C4/SIP/Trapper.pm
>index 774b3a0c57..ef99b5de17 100644
>--- a/C4/SIP/Trapper.pm
>+++ b/C4/SIP/Trapper.pm
>@@ -35,6 +35,10 @@ sub PRINT {
>     $Log::Log4perl::caller_depth--;
> }
> 
>+sub OPEN {
>+    return 1;
>+}
>+
> =head2 BINMODE
> 
>     Suppress errors from Log::Log4perl::Appender::Screen
>diff --git a/debian/templates/SIPconfig.xml b/debian/templates/SIPconfig.xml
>index c9a1717794..dc1ca38a4d 100644
>--- a/debian/templates/SIPconfig.xml
>+++ b/debian/templates/SIPconfig.xml
>@@ -10,7 +10,7 @@
>   <server-params
>     min_servers='1'
>     min_spare_servers='0'
>-    log_file='Sys::Syslog'
>+    log_file='/var/log/koha/__KOHASITE__/sip.log'
>     syslog_ident='koha_sip'
>     syslog_facility='local6'
>   />
>@@ -23,7 +23,7 @@
>       protocol="NCIP/1.0" />
> -->
>     <service
>-      port="8023/tcp"
>+      port="127.0.0.1:8023/tcp"
>       transport="telnet"
>       protocol="SIP/2.00"
>       timeout="60" />
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36948: 167112 | 167134 | 167147 | 167148 | 167149 | 167150 | 167151 | 167152 | 167153