Attachment 167157 Details for Bug 36923 – Bug 36923: Remove warnings from Holds/LocalHoldsPriority.t

[patch] Bug 36923: Remove warnings from Holds/LocalHoldsPriority.t

Bug-36923-Remove-warnings-from-HoldsLocalHoldsPrio.patch (text/plain), 1.89 KB, created by Marcel de Rooy on 2024-05-24 09:32:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-05-24 09:32:34 UTC

Size: 1.89 KB

patch

obsolete

>From 4ce66bcde445e83001e7e5b5f90f227c7d2eb0b1 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 22 May 2024 14:01:28 +0200
>Subject: [PATCH] Bug 36923: Remove warnings from Holds/LocalHoldsPriority.t
>Content-Type: text/plain; charset=utf-8
>
>t/db_dependent/Holds/LocalHoldsPriority.t .. 1/7 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.
>t/db_dependent/Holds/LocalHoldsPriority.t .. 2/7 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.
>Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.
>Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.
>t/db_dependent/Holds/LocalHoldsPriority.t .. 5/7 Use of uninitialized value in numeric gt (>) at /kohadevbox/koha/C4/Reserves.pm line 866.
>t/db_dependent/Holds/LocalHoldsPriority.t .. ok
>All tests successful.
>
>We didn't have the default values generated by the DBMS
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Holds/LocalHoldsPriority.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/Holds/LocalHoldsPriority.t b/t/db_dependent/Holds/LocalHoldsPriority.t
>index 95af26981f..7638130e20 100755
>--- a/t/db_dependent/Holds/LocalHoldsPriority.t
>+++ b/t/db_dependent/Holds/LocalHoldsPriority.t
>@@ -51,7 +51,7 @@ my $item = Koha::Item->new(
>         itype         => $itemtype,
>         exclude_from_local_holds_priority => 0,
>     },
>-)->store;
>+)->store->get_from_storage;
> 
> my @branchcodes = ( $library1->{branchcode}, $library2->{branchcode}, $library3->{branchcode}, $library4->{branchcode}, $library3->{branchcode}, $library4->{branchcode} );
> my $patron_category = $builder->build({ source => 'Category', value => {exclude_from_local_holds_priority => 0} });
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36923: 167024 | 167056 | 167157