Attachment 167194 Details for Bug 34838 – [23.11.x] Bug 34838: (QA follow-up): TypeDisclaimer tests - Add 'type' to request metadata

[patch] [23.11.x] Bug 34838: (QA follow-up): TypeDisclaimer tests - Add 'type' to request metadata

2311x-Bug-34838-QA-follow-up-TypeDisclaimer-tests-.patch (text/plain), 1.37 KB, created by Pedro Amorim on 2024-05-27 15:05:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-05-27 15:05:57 UTC

Size: 1.37 KB

patch

obsolete

>From 29669117425354945c19f26beecf9844ed500a73 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Mon, 27 May 2024 14:43:41 +0000
>Subject: [PATCH] [23.11.x] Bug 34838: (QA follow-up): TypeDisclaimer tests -
> Add 'type' to request metadata
>
>This adds a type to the request (mocking it as a new ILL request of type journal being submitted)
>---
> t/db_dependent/Illrequest/TypeDisclaimer.t | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Illrequest/TypeDisclaimer.t b/t/db_dependent/Illrequest/TypeDisclaimer.t
>index 402bb5002e..1246ef5c3f 100755
>--- a/t/db_dependent/Illrequest/TypeDisclaimer.t
>+++ b/t/db_dependent/Illrequest/TypeDisclaimer.t
>@@ -37,7 +37,8 @@ use_ok('Koha::Illrequest::Workflow::TypeDisclaimer');
> 
> my $metadata = {
>     title  => 'This is a title',
>-    author => 'This is an author'
>+    author => 'This is an author',
>+    type   => 'journal'
> };
> 
> # Because hashes can reorder themselves, we need to make sure ours is in a
>@@ -54,7 +55,7 @@ isa_ok( $type_disclaimer, 'Koha::Illrequest::Workflow::TypeDisclaimer' );
> 
> is(
>     $type_disclaimer->prep_metadata($sorted),
>-'eyJhdXRob3IiOiJUaGlzIGlzIGFuIGF1dGhvciIsInRpdGxlIjoiVGhpcyBpcyBhIHRpdGxlIn0%3D%0A',
>+'eyJhdXRob3IiOiJUaGlzIGlzIGFuIGF1dGhvciIsInRpdGxlIjoiVGhpcyBpcyBhIHRpdGxlIiwi%0AdHlwZSI6ImpvdXJuYWwifQ%3D%3D%0A',
>     'prep_metadata works'
> );
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 34838: 156178 | 156200 | 156201 | 156202 | 156204 | 156217 | 156218 | 156219 | 156220 | 166841 | 166842 | 166843 | 166844 | 166845 | 166846 | 166847 | 166848 | 166849 | 166850 | 166851 | 166852 | 166853 | 166854 | 166855 | 167193 | 167194 | 167211 | 167212 | 167213 | 167214 | 167215 | 167216