Attachment 167195 Details for Bug 36966 – Bug 36966: Fix local cover image links for items

[patch] Bug 36966: Fix local cover image links for items

Bug-36966-Fix-local-cover-image-links-for-items.patch (text/plain), 2.35 KB, created by David Nind on 2024-05-27 20:02:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-05-27 20:02:35 UTC

Size: 2.35 KB

patch

obsolete

>From e3496ef3b8df5ae452bb201a7e047dc0e6cf90a2 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 27 May 2024 03:33:06 +0000
>Subject: [PATCH] Bug 36966: Fix local cover image links for items
>
>This change fixes the local cover image links for items by removing
>unnecessary parameters, an invalid link, and an uninitialised
>Template::Toolkit variable.
>
>Test plan:
>0. Apply patch
>1. Enable syspref 'LocalCoverImages'
>3. Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=29
>4. Click on the dropdown next to "Edit" at the item level
>5. Upload an image for the item
>6. Note that the local cover image appears in the holdings table
>7. Click on the image and note that it loads in the light box
>8. Success!
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> .../includes/html_helpers/tables/items/catalogue_detail.inc   | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 3c08fe3ec7..7b3e7b6fe5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -326,8 +326,8 @@
>                     node += '<div class="cover-slider">';
>                     row.cover_image_ids.forEach(id => {
>                         node += '<div class="cover-image local-coverimg">';
>-                        node += '<a href="/cgi-bin/koha/catalogue/image.pl?itemnumber=%s&amp;imagenumber=%s" title="%s">'.format(id, id, _("Local cover image"));
>-                        node += '<img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&amp;imagenumber=%s" alt="%s" data-link="/cgi-bin/koha/catalogue/imageviewer.pl?itemnumber=[% item.itemnumber | uri %]&amp;imagenumber=%s" />'.format(id, id, _("Local cover image"));
>+                        node += '<a href="/cgi-bin/koha/catalogue/image.pl?imagenumber=%s" title="%s">'.format(id, _("Local cover image"));
>+                        node += '<img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&imagenumber=%s" alt="%s" />'.format(id, _("Local cover image"));
>                         node += '</a>';
>                         node += '</div>';
>                     });
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36966: 167187 | 167195 | 167236 | 167254 | 167255 | 167259 | 167263 | 167264 | 167265 | 168090 | 168091 | 168092