Attachment 167217 Details for Bug 36956 – Bug 36956: Allow all providers to be displayed in reports

[patch] Bug 36956: Allow all providers to be displayed in reports

Bug-36956-Allow-all-providers-to-be-displayed-in-r.patch (text/plain), 1.48 KB, created by Matt Blenkinsop on 2024-05-28 10:42:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-05-28 10:42:46 UTC

Size: 1.48 KB

patch

obsolete

>From 66fb3856f6fac2da57688362abd970a03dd98be6 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Tue, 28 May 2024 10:39:33 +0000
>Subject: [PATCH] Bug 36956: Allow all providers to be displayed in reports
>
>This patch fixes an incorrect usage of the API which was only returning 20 results.
>
>Test plan:
>1) Go to ERM module and make sure you have more than 21 data providers stored in your database.
>2) Go to eUsage / reports and create new report (cgi-bin/koha/erm/eusage/reports)
>3) Check that only the first 20 data providers are displayed in the drop down
>4) Apply patch
>5) yarn build or reset_all to rebuild the javascript
>6) Repeat steps 1-3, all providers should now be displayed
>---
> koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js b/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js
>index c69dada53b..c23ecb1a51 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/fetch/erm-api-client.js
>@@ -263,7 +263,7 @@ export class ERMAPIClient extends HttpClient {
>                     endpoint: "usage_data_providers/" + id,
>                 }),
>             getAll: query =>
>-                this.get({
>+                this.getAll({
>                     endpoint: "usage_data_providers",
>                     query,
>                     query,
>-- 
>2.37.1 (Apple Git-137.1)

Actions: View | Diff | Splinter Review

Attachments on bug 36956: 167217 | 167221 | 167933