Attachment 167236 Details for Bug 36966 – Bug 36966: Fix data-link for local cover images

[patch] Bug 36966: Fix data-link for local cover images

Bug-36966-Fix-data-link-for-local-cover-images.patch (text/plain), 1.71 KB, created by David Cook on 2024-05-29 07:27:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2024-05-29 07:27:18 UTC

Size: 1.71 KB

patch

obsolete

>From ffa0bb14d792e7978eefbd63ead1de066fb5067b Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Wed, 29 May 2024 07:26:18 +0000
>Subject: [PATCH] Bug 36966: Fix data-link for local cover images
>
>This patch fixes the data-link so that the "edit" link at the
>bottom of the lightbox viewer correctly takes the user to
>the editor interface for the local cover image
>---
> .../en/includes/html_helpers/tables/items/catalogue_detail.inc  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 7b3e7b6fe5..799fa1ab0e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -327,7 +327,7 @@
>                     row.cover_image_ids.forEach(id => {
>                         node += '<div class="cover-image local-coverimg">';
>                         node += '<a href="/cgi-bin/koha/catalogue/image.pl?imagenumber=%s" title="%s">'.format(id, _("Local cover image"));
>-                        node += '<img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&imagenumber=%s" alt="%s" />'.format(id, _("Local cover image"));
>+                        node += '<img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&imagenumber=%s" data-link="/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=%s&imagenumber=%s" alt="%s" />'.format(id, row.biblio_id, id, _("Local cover image"));
>                         node += '</a>';
>                         node += '</div>';
>                     });
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36966: 167187 | 167195 | 167236 | 167254 | 167255 | 167259 | 167263 | 167264 | 167265 | 168090 | 168091 | 168092