Attachment 167259 Details for Bug 36966 – Bug 36966: Actually fix data-link for local cover images

[patch] Bug 36966: Actually fix data-link for local cover images

Bug-36966-Actually-fix-data-link-for-local-cover-i.patch (text/plain), 1.65 KB, created by David Cook on 2024-05-30 04:17:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Cook

Created: 2024-05-30 04:17:35 UTC

Size: 1.65 KB

patch

obsolete

>From bc805af38c20c303ed12d7107097c10a8a0c0cab Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 30 May 2024 04:16:56 +0000
>Subject: [PATCH] Bug 36966: Actually fix data-link for local cover images
>
>---
> .../en/includes/html_helpers/tables/items/catalogue_detail.inc  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 799fa1ab0e..7c221abbb7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -327,7 +327,7 @@
>                     row.cover_image_ids.forEach(id => {
>                         node += '<div class="cover-image local-coverimg">';
>                         node += '<a href="/cgi-bin/koha/catalogue/image.pl?imagenumber=%s" title="%s">'.format(id, _("Local cover image"));
>-                        node += '<img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&imagenumber=%s" data-link="/cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=%s&imagenumber=%s" alt="%s" />'.format(id, row.biblio_id, id, _("Local cover image"));
>+                        node += '<img src="/cgi-bin/koha/catalogue/image.pl?thumbnail=1&imagenumber=%s" data-link="/cgi-bin/koha/catalogue/imageviewer.pl?itemnumber=%s&imagenumber=%s" alt="%s" />'.format(id, row.item_id, id, _("Local cover image"));
>                         node += '</a>';
>                         node += '</div>';
>                     });
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36966: 167187 | 167195 | 167236 | 167254 | 167255 | 167259 | 167263 | 167264 | 167265 | 168090 | 168091 | 168092