Attachment 167274 Details for Bug 36940 – Bug 36940: Resolve two warnings on undefined branchip

[patch] Bug 36940: Resolve two warnings on undefined branchip

Bug-36940-Resolve-two-warnings-on-undefined-branch.patch (text/plain), 1.63 KB, created by Nick Clemens (kidclamp) on 2024-05-30 13:36:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-05-30 13:36:52 UTC

Size: 1.63 KB

patch

obsolete

>From 5cb4eac86efb59eb71a3b32c4e80c9973d8272d4 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 23 May 2024 08:47:50 +0000
>Subject: [PATCH] Bug 36940: Resolve two warnings on undefined branchip
>
>If you enabled AutoLocation and have a branch without ip, this
>triggers warnings.
>
>Test plan:
>Check logs in this situation with/without this patch by logging out
>and in again on staff.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Auth.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index bc1f2c945e2..17bdef44656 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -1218,10 +1218,10 @@ sub checkauth {
>                         my $branches = { map { $_->branchcode => $_->unblessed } Koha::Libraries->search->as_list };
>                         if ( C4::Context->preference('StaffLoginRestrictLibraryByIP') ) {
>                             # we have to check they are coming from the right ip range
>-                            my $domain = $branches->{$branchcode}->{'branchip'};
>+                            my $domain = $branches->{$branchcode}->{'branchip'} // q{};
>                             $domain =~ s|\.\*||g;
>                             $domain =~ s/\s+//g;
>-                            if ( $ip !~ /^$domain/ ) {
>+                            if ( $domain && $ip !~ /^$domain/ ) {
>                                 $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie(
>                                     -name     => 'CGISESSID',
>                                     -value    => '',
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36940: 167079 | 167274