Bugzilla – Attachment 167283 Details for
Bug 36575
Wrong patron can be returned for API validation route
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36575: (QA follow-up) Shibboleth POD and checkpw_internal call
Bug-36575-QA-follow-up-Shibboleth-POD-and-checkpwi.patch (text/plain), 1.53 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-05-30 16:54:58 UTC
(
hide
)
Description:
Bug 36575: (QA follow-up) Shibboleth POD and checkpw_internal call
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-05-30 16:54:58 UTC
Size:
1.53 KB
patch
obsolete
>From 3c510f75241ea28feb026f7142065e1c11b85ca8 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 30 Apr 2024 14:39:36 +0000 >Subject: [PATCH] Bug 36575: (QA follow-up) Shibboleth POD and checkpw_internal > call > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > C4/Auth.pm | 4 ++-- > C4/Auth_with_shibboleth.pm | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/C4/Auth.pm b/C4/Auth.pm >index b81a99bc564..26240a425b0 100644 >--- a/C4/Auth.pm >+++ b/C4/Auth.pm >@@ -2043,8 +2043,8 @@ sub checkpw { > > # INTERNAL AUTH > @return = checkpw_internal( $userid, $password, $no_set_userenv ); >- $passwd_ok = 1 if $return[0] > 0; # 1 or 2 >- $patron = $return[3]; >+ $passwd_ok = $return[0]; >+ $patron = $passwd_ok ? $return[3] : undef; > } > > if ( defined $userid && !$patron ) { >diff --git a/C4/Auth_with_shibboleth.pm b/C4/Auth_with_shibboleth.pm >index f9ba592b3e3..3e6f42b57c6 100644 >--- a/C4/Auth_with_shibboleth.pm >+++ b/C4/Auth_with_shibboleth.pm >@@ -409,7 +409,7 @@ This routine is NOT exported > > =head2 _autocreate > >- my ( $retval, $retcard, $retuserid ) = _autocreate( $config, $match ); >+ my ( $retval, $retcard, $retuserid, $patron ) = _autocreate( $config, $match, $patron ); > > Given a shibboleth attribute reference and a userid this internal routine will add the given user to Koha and return their user credentials. > >-- >2.45.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36575
:
164668
|
164670
|
164671
|
165133
|
165134
|
165467
|
165468
|
165469
|
165470
|
165471
|
165908
|
166493
|
166494
|
166495
|
166496
|
166497
|
166498
|
167276
|
167277
|
167278
|
167279
|
167280
|
167281
|
167282
| 167283