Attachment 167445 Details for Bug 37035 – Bug 37035: Merging authorities triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled

[patch] Bug 37035: Merging authorities triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled

Bug-37035-Merging-authorities-triggers-rebuilding-.patch (text/plain), 1.57 KB, created by Kyle M Hall (khall) on 2024-06-05 14:59:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-06-05 14:59:15 UTC

Size: 1.57 KB

patch

obsolete

>From 87c2e043f5e1bf8c4d20ea221dfb1e89ae610acf Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 5 Jun 2024 10:53:26 -0400
>Subject: [PATCH] Bug 37035: Merging authorities triggers rebuilding holds for
> all affected records when RealTimeHoldsQueue is enabled
>
>If RealTimeHoldsQueue is on, merging authorities triggers a update_holds_queue_for_biblios background job for each affected record. This can result in thousands of unnecessary queued jobs since this change will not affect hold-ability. In a large catalog this can be a crippling number of background jobs that will delay more important jobs.
>
>Test Plan:
>1) Enable RealTimeHoldsQueue
>2) Merge authorities with merge_authorities.pl
>3) Note a update_holds_queue_for_biblios background job is queued for each record touched
>4) Apply this match
>5) Merge authorities again
>6) Note that no update_holds_queue_for_biblios jobs were queued
>---
> C4/AuthoritiesMarc.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/C4/AuthoritiesMarc.pm b/C4/AuthoritiesMarc.pm
>index 70c5903dc49..0786d340997 100644
>--- a/C4/AuthoritiesMarc.pm
>+++ b/C4/AuthoritiesMarc.pm
>@@ -1648,7 +1648,10 @@ sub merge {
>             }
>         }
>         next if !$update;
>-        ModBiblio( $marcrecord, $biblio->biblionumber, $biblio->frameworkcode, { disable_autolink => 1 } );
>+        ModBiblio(
>+            $marcrecord, $biblio->biblionumber, $biblio->frameworkcode,
>+            { disable_autolink => 1, skip_holds_queue => 1 }
>+        );
>         $counteditedbiblio++;
>     }
>     return $counteditedbiblio;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37035: 167444 | 167445 | 167456 | 167662