Attachment 167450 Details for Bug 37037 – Bug 37037: touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled

[patch] Bug 37037: touch_all_biblios.pl triggers rebuilding holds for all affected records when RealTimeHoldsQueue is enabled

Bug-37037-touchallbibliospl-triggers-rebuilding-ho.patch (text/plain), 1.61 KB, created by Kyle M Hall (khall) on 2024-06-05 15:06:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-06-05 15:06:42 UTC

Size: 1.61 KB

patch

obsolete

>From 87d42221303d8a8895cc107be88964d565855f31 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 5 Jun 2024 11:04:31 -0400
>Subject: [PATCH] Bug 37037: touch_all_biblios.pl triggers rebuilding holds for
> all affected records when RealTimeHoldsQueue is enabled
>
>If RealTimeHoldsQueue is on, touch_all_biblios triggers a update_holds_queue_for_biblios background job for each affected record. This will result in a as many background jobs being queued up as records! It makes far more sense for this script to not do that which gives the administrator the option for running the holds queue builder if the changes would affect holdability, or to not run it at all.
>
>Test Plan:
>1) Run touch_all_biblios.pl
>3) Note a update_holds_queue_for_biblios background job is queued for each record touched
>4) Apply this patch
>5) Merge touch_all_biblios.pl again
>6) Note that no update_holds_queue_for_biblios jobs were queued
>---
> misc/maintenance/touch_all_biblios.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/misc/maintenance/touch_all_biblios.pl b/misc/maintenance/touch_all_biblios.pl
>index 956b7677ad7..15155089d80 100755
>--- a/misc/maintenance/touch_all_biblios.pl
>+++ b/misc/maintenance/touch_all_biblios.pl
>@@ -79,7 +79,7 @@ while (my ($biblionumber, $frameworkcode) = $sth1->fetchrow_array){
>   my $biblio = Koha::Biblios->find($biblionumber);
>   my $record = $biblio->metadata->record;
> 
>-  my $modok = ModBiblio($record, $biblionumber, $frameworkcode);
>+my $modok = ModBiblio( $record, $biblionumber, $frameworkcode, { skip_holds_queue => 1 } );
> 
>   if ($modok) {
>      $goodcount++;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37037: 167450 | 167455 | 167660