Bugzilla – Attachment 167453 Details for
Bug 37021
REST API: Holds endpoint handles item_id as string in GET call
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37021: Change item_id type as integer in holds endpoint
Bug-37021-Change-itemid-type-as-integer-in-holds-e.patch (text/plain), 1.32 KB, created by
Matt Blenkinsop
on 2024-06-05 15:19:37 UTC
(
hide
)
Description:
Bug 37021: Change item_id type as integer in holds endpoint
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-06-05 15:19:37 UTC
Size:
1.32 KB
patch
obsolete
>From 1d5a73999b1274a4bf176cef1129ebc867d02fc3 Mon Sep 17 00:00:00 2001 >From: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> >Date: Tue, 4 Jun 2024 13:00:05 +0300 >Subject: [PATCH] Bug 37021: Change item_id type as integer in holds endpoint > >When one makes a GET call to holds endpoint and hold has >item attached to it, item_id is handled as string not integer >as it should. > >To reproduce: >1. Make sure you have hold waiting in your database. >2. Call endpoint api/v1/holds/?q=[{"me.status":"W"}]. >=> Note that holds item_id is displayed as item_id: "12345". >3. Apply this patch. >4. Call endpoint again. >=> item_id should now be displayed as 12345. > >Also prove t/db_dependent/api/v1/holds.t. > >Signed-off-by: Jan Kissig <jkissig@th-wildau.de> >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >--- > api/v1/swagger/definitions/hold.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/api/v1/swagger/definitions/hold.yaml b/api/v1/swagger/definitions/hold.yaml >index ae2c055a30..85bcd66900 100644 >--- a/api/v1/swagger/definitions/hold.yaml >+++ b/api/v1/swagger/definitions/hold.yaml >@@ -64,7 +64,7 @@ properties: > description: Timestamp for the latest hold update > item_id: > type: >- - string >+ - integer > - "null" > description: Internal item identifier > waiting_date: >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37021
:
167370
|
167430
| 167453