Attachment 167457 Details for Bug 37023 – Bug 37023: Update timestamp when filling a hold

[patch] Bug 37023: Update timestamp when filling a hold

Bug-37023-Update-timestamp-when-filling-a-hold.patch (text/plain), 2.31 KB, created by Matt Blenkinsop on 2024-06-05 15:43:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-06-05 15:43:39 UTC

Size: 2.31 KB

patch

obsolete

>From ddc9ff69a2b45b92976c92b4c305044adb816a0e Mon Sep 17 00:00:00 2001
>From: Johanna Raisa <johanna.raisa@gmail.com>
>Date: Tue, 4 Jun 2024 14:44:56 +0300
>Subject: [PATCH] Bug 37023: Update timestamp when filling a hold
>
>This patch updates the timestamp of the hold when it is filled and moved to old_reserves.
>
>Test plan:
>1) Apply the patch
>2) prove t/db_dependent/Koha/Hold.t
>
>Sponsored-by: Koha-Suomi Oy
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>---
> Koha/Hold.pm               | 1 +
> t/db_dependent/Koha/Hold.t | 6 ++++--
> 2 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Hold.pm b/Koha/Hold.pm
>index 12109ad573..cd41ca853e 100644
>--- a/Koha/Hold.pm
>+++ b/Koha/Hold.pm
>@@ -848,6 +848,7 @@ sub fill {
>                 {
>                     found    => 'F',
>                     priority => 0,
>+                    timestamp => dt_from_string->strftime( '%Y-%m-%d %H:%M:%S' ),
>                     $params->{item_id} ? ( itemnumber => $params->{item_id} ) : (),
>                 }
>             );
>diff --git a/t/db_dependent/Koha/Hold.t b/t/db_dependent/Koha/Hold.t
>index 99dae133a2..e8d1dc5155 100755
>--- a/t/db_dependent/Koha/Hold.t
>+++ b/t/db_dependent/Koha/Hold.t
>@@ -106,7 +106,7 @@ subtest 'pickup_library/branch tests' => sub {
> 
> subtest 'fill() tests' => sub {
> 
>-    plan tests => 14;
>+    plan tests => 15;
> 
>     $schema->storage->txn_begin;
> 
>@@ -136,6 +136,7 @@ subtest 'fill() tests' => sub {
>                 biblionumber   => $biblio->id,
>                 borrowernumber => $patron->id,
>                 itemnumber     => $item->id,
>+                timestamp      => dt_from_string('2021-06-25 14:05:35'),
>                 priority       => 10,
>             }
>         }
>@@ -148,7 +149,7 @@ subtest 'fill() tests' => sub {
> 
>     my $interface = 'api';
>     C4::Context->interface($interface);
>-
>+    my $hold_timestamp = $hold->timestamp;
>     my $ret = $hold->fill;
> 
>     is( ref($ret), 'Koha::Hold', '->fill returns the object type' );
>@@ -159,6 +160,7 @@ subtest 'fill() tests' => sub {
> 
>     is( $old_hold->id, $hold->id, 'reserve_id retained' );
>     is( $old_hold->priority, 0, 'priority set to 0' );
>+    isnt( $old_hold->timestamp, $hold_timestamp, 'timestamp updated' );
>     is( $old_hold->found, 'F', 'found set to F' );
> 
>     subtest 'item_id parameter' => sub {
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 37023: 167378 | 167457 | 171904