Bugzilla – Attachment 167459 Details for
Bug 25520
Change wording on SMS phone number set up
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25520: Fix the SMS number input hint on the OPAC messaging page
Bug-25520-Fix-the-SMS-number-input-hint-on-the-OPA.patch (text/plain), 2.76 KB, created by
Matt Blenkinsop
on 2024-06-05 15:56:08 UTC
(
hide
)
Description:
Bug 25520: Fix the SMS number input hint on the OPAC messaging page
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-06-05 15:56:08 UTC
Size:
2.76 KB
patch
obsolete
>From c647d07076bfa5af87523e86a8f817a9edd0b789 Mon Sep 17 00:00:00 2001 >From: David Nind <david@davidnind.com> >Date: Tue, 4 Jun 2024 01:57:37 +0000 >Subject: [PATCH] Bug 25520: Fix the SMS number input hint on the OPAC > messaging page > >This makes the hint when entering an SMS number on the OPAC messaging >settings page the same as the staff interface hint: "Please enter >numbers only. Prefix the number with + or 00 if including the country >code." For some countries using either +XX or 00XX are accepted, >for example: +49 or 0049. > >Test plan: >1. Set the SMSSendDriver system preference to Email >2. View the current hint for entering an SMS number in the staff > interface: > 2.1 Go to Patrons > + New patron > Patron. > 2.2 Scroll down to the 'Patron messaging preferences' section at the > end of the page. > 2.3 Note that the hint is "Please enter numbers only. Prefix the > number with + or 00 if including the country code.". >3. View the current hint for entering an SMS number in the OPAC: > 3.1 Go to the OPAC > Your account (log in if required). > 3.2 Select the 'Messaging' tab/section. > 3.3 Note that the hint is "Please enter numbers only. Prefix the > number with + if including the country code.". > 3.4 The difference: "..or 00.." is missing. >4. Apply the patch. >5. Refresh the OPAC messaging page. >6. The hint text for the OPAC is now the same as the staff interface. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Sam Lau <samalau@gmail.com> >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >index 84a5c79d27..5026b17dd5 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >@@ -191,7 +191,7 @@ > <li> > <label for="SMSnumber">SMS number:</label> > <input type="text" id="SMSnumber" name="SMSnumber" value="[% SMSnumber | html %]" pattern="^(\+[1-9]\d{0,2})?\d{1,12}$" /> >- <span class="hint sms_number_help">Please enter numbers only. Prefix the number with + if including the country code.</span> >+ <span class="hint sms_number_help">Please enter numbers only. Prefix the number with + or 00 if including the country code.</span> > </li> > > [% IF ( SMSSendDriver == 'Email' ) %] >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25520
:
167367
|
167409
| 167459