Bugzilla – Attachment 167565 Details for
Bug 36894
Journal article request authors do not show in the ILL requests table
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36894: Display journal article ILL request author
Bug-36894-Display-journal-article-ILL-request-auth.patch (text/plain), 1.75 KB, created by
Martin Renvoize (ashimema)
on 2024-06-07 09:52:25 UTC
(
hide
)
Description:
Bug 36894: Display journal article ILL request author
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-06-07 09:52:25 UTC
Size:
1.75 KB
patch
obsolete
>From 20e41fdd143e1d0e848590978293c178351e1649 Mon Sep 17 00:00:00 2001 >From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >Date: Fri, 17 May 2024 10:25:52 +0000 >Subject: [PATCH] Bug 36894: Display journal article ILL request author > >This patch fixes the ILL request table to display authors for journal article request types > >Test plan: >1) Create an ILL request with the type of Journal Article and add an author in the Article author field >2) Click on the List requests button to see the table >3) The Author field should be blank for the request you created >4) Apply patch >5) Hard refresh the browser to reload the javascript >6) The author field should now be visible > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >index 8138ca5dd79..d1aefcc5e8d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/ill-list-table.js >@@ -247,7 +247,11 @@ $(document).ready(function() { > "data": "", // author > "orderable": false, > "render": function(data, type, row, meta) { >- return display_extended_attribute(row, 'author'); >+ const author = display_extended_attribute(row, 'author'); >+ if(author) return author >+ const articleAuthor = display_extended_attribute(row, 'article_author'); >+ if(articleAuthor) return articleAuthor >+ return '' > } > }, > { >-- >2.45.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36894
:
166882
|
166925
| 167565