Attachment 167566 Details for Bug 36983 – Bug 36983: Fix incorrect required class

[patch] Bug 36983: Fix incorrect required class

Bug-36983-Fix-incorrect-required-class.patch (text/plain), 2.22 KB, created by Martin Renvoize (ashimema) on 2024-06-07 09:54:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-06-07 09:54:59 UTC

Size: 2.22 KB

patch

obsolete

>From 4075be0c845ecd562add280573b827ae1cf8eb05 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 29 May 2024 11:06:31 +0000
>Subject: [PATCH] Bug 36983: Fix incorrect required class
>
>This patch fixes an error on the B_address2 field which sets it to be
>required incorrectly
>
>Test plan:
>1) In PatronSelfRegistrationBorrowerMandatoryField, set B_address to be
>   required.
>2) In the OPAC, navigate to the self registration form.
>3) In the Alternate address section, fill in the Address field that you
>   have just set to be required. Ensure that you leave the Address 2
>   field blank.
>4) Fill in all other required fields and submit the form, it should show
>   you that the Address 2 field is required, even though it shouldn't be
>5) Apply patch
>6) Refresh the page and repeat steps 1-5, it should allow youto submit
>   the form
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index d3333eaeb34..f96165ddde6 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -763,7 +763,7 @@
>                                             <li>
>                                                 <label for="borrower_B_address2" class="[% required.B_address | html %]">Address 2:</label>
> 
>-                                                <input type="text" id="borrower_B_address2" name="borrower_B_address2" value="[% borrower.B_address2 | html %]" class="[% required.B_address | html %]" />
>+                                                <input type="text" id="borrower_B_address2" name="borrower_B_address2" value="[% borrower.B_address2 | html %]" class="[% required.B_address2 | html %]" />
>                                                 <div class="required_label [% required.B_address2 | html %]">Required</div>
>                                             </li>
>                                         [% END %]
>-- 
>2.45.2

Actions: View | Diff | Splinter Review

Attachments on bug 36983: 167238 | 167240 | 167566