Bugzilla – Attachment 167574 Details for
Bug 35869
Dismissing an OPAC message from SCO logs the user out
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35869: Removes the dismiss button from messages on OPAC SCO module
Bug-35869-Removes-the-dismiss-button-from-messages.patch (text/plain), 4.14 KB, created by
Matt Blenkinsop
on 2024-06-07 12:46:25 UTC
(
hide
)
Description:
Bug 35869: Removes the dismiss button from messages on OPAC SCO module
Filename:
MIME Type:
Creator:
Matt Blenkinsop
Created:
2024-06-07 12:46:25 UTC
Size:
4.14 KB
patch
obsolete
>From ee0375678e70ad6caabc48d11c324ac37d8e7b86 Mon Sep 17 00:00:00 2001 >From: Sam Lau <samalau@gmail.com> >Date: Wed, 5 Jun 2024 17:57:10 +0000 >Subject: [PATCH] Bug 35869: Removes the dismiss button from messages on OPAC > SCO module > >This removes the "Dismiss" button from the SCO module. Currently, the >"Dismiss" button is present, however it does not function properly and >logs the user out if they press it. As noted on previous chats, keeping >the button would require serious changes, thus it's easier just to remove >the functionallity. > >To test: >1) Enable WebBasedSelfCheck >2) Add an OPAC mesaage to a patron account >3) Login to self check ( http://localhost:8080/cgi-bin/koha/sco/sco-main.pl ) >4) See the OPAC message, click dismiss. >5) Notice you are logged out at redirected to: > ( http://localhost:8080/cgi-bin/koha/opac-dismiss-message.pl ) >6) Apply patch >7) Log back into the self checkout module >8) Notice that there is no longer a "Dismiss" button for the message. >9) Log into OPAC into the same user's account >10) On the summary page, note that there is still a dismiss button. >11) Ensure this still works properly >12) sign-off > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> >--- > .../opac-tmpl/bootstrap/en/includes/opac-note.inc | 14 ++++++++------ > .../opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 2 +- > 2 files changed, 9 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc >index 513d963775..12f86fb34d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc >@@ -7,12 +7,14 @@ > <strong>[% message.message | html | html_line_break %]</strong><br> > <em>Written on [% message.message_date | $KohaDates %] by [% Branches.GetName(message.branchcode) | html %]</em> > </li> >- <form id="dismiss-message-form" class="d-print-none" action="/cgi-bin/koha/opac-dismiss-message.pl" method="post"> >- [% INCLUDE 'csrf-token.inc' %] >- <input type="hidden" name="message_id" value="[% message.message_id | html %]"> >- <input type="hidden" name="op" value="cud-update" /> >- <button type="submit" class="dismiss-message-button btn btn-primary"><i class="fa fa-trash" aria-hidden="true"></i> Dismiss</button> >- </form> >+ [% IF sco != "true" %] >+ <form id="dismiss-message-form" class="d-print-none" action="/cgi-bin/koha/opac-dismiss-message.pl" method="post"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <input type="hidden" name="message_id" value="[% message.message_id | html %]"> >+ <input type="hidden" name="op" value="cud-update" /> >+ <button type="submit" class="dismiss-message-button btn btn-primary"><i class="fa fa-trash" aria-hidden="true"></i> Dismiss</button> >+ </form> >+ [% END %] > [% END %] > > [% IF ( opacnote ) %]<li>[% opacnote | html | html_line_break %]</li>[% END %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index cd369b559d..ded28e6809 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -246,7 +246,7 @@ > [% IF ( patronid ) %] > [% IF ( validuser ) %] > <div class="alert alert-info">You are logged in as [% borrowername | html %].</div> >- [% INCLUDE 'opac-note.inc' %] >+ [% INCLUDE 'opac-note.inc' sco="true" %] > [% IF patron_has_hold_fee %] > <div class="alert alert-warning">A hold fee was charged to your account for collecting this item.</div> > [% END %] >-- >2.39.3 (Apple Git-146)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35869
:
167489
|
167495
| 167574