Bugzilla – Attachment 167639 Details for
Bug 36207
Update browser alerts to modals: OPAC tags
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36207: (RM follow-up) CSRF correction
Bug-36207-RM-follow-up-CSRF-correction.patch (text/plain), 2.24 KB, created by
Martin Renvoize (ashimema)
on 2024-06-11 15:16:27 UTC
(
hide
)
Description:
Bug 36207: (RM follow-up) CSRF correction
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-06-11 15:16:27 UTC
Size:
2.24 KB
patch
obsolete
>From 0ac23a624735c222bf9358d37961e6c49c21c579 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Tue, 11 Jun 2024 16:13:36 +0100 >Subject: [PATCH] Bug 36207: (RM follow-up) CSRF correction > >I think there was a rebase issue here where we split the form into two >forms instead of one. This patch returns us to one form with two >different submit options (one for selected tags and one per tag) that >both trigger the confirmation modal before submitting to the controller. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >index b103319c6ea..86ffb37dec8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-tags.tt >@@ -127,7 +127,9 @@ > [% END # /add_op %] > > [% IF ( MY_TAGS ) %] >- <form method="post" action="opac-tags.pl"> >+ <form id="deletetags" name="deletetags" method="post" action="opac-tags.pl"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <input type="hidden" name="op" value="cud-del" /> > <table id="mytagst" class="table table-bordered table-striped"> > <caption>Your tags</caption> > <thead> >@@ -183,10 +185,6 @@ > </table> > <input type="submit" value="Remove selected tags" class="btn btn-danger remove"> > </form> >- <form id="deletetags" name="deletetags" method="post" action="/cgi-bin/koha/opac-tags.pl"> >- [% INCLUDE 'csrf-token.inc' %] >- <input type="hidden" name="op" value="cud-del" /> >- </form> > [% END # /MY_TAGS %] > </div> <!-- / .usertags --> > </div> <!-- / .span10/12 --> >-- >2.45.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36207
:
163575
|
163578
|
166212
|
167394
| 167639