Attachment 167654 Details for Bug 35257 – Bug 35257: Change 'Circulation desks' to 'Desks'

[patch] Bug 35257: Change 'Circulation desks' to 'Desks'

Bug-35257-Change-Circulation-desks-to-Desks.patch (text/plain), 2.99 KB, created by Pedro Amorim on 2024-06-12 12:40:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-06-12 12:40:29 UTC

Size: 2.99 KB

patch

obsolete

>From 6c94b4dec96a99232cdd9731dd66cd0d82e0b86d Mon Sep 17 00:00:00 2001
>From: David Nind <david@davidnind.com>
>Date: Sat, 8 Jun 2024 06:19:53 +0000
>Subject: [PATCH] Bug 35257: Change 'Circulation desks' to 'Desks'
>
>The administration page is the only page that uses "Circulation desks" for
>navigation elements. All other areas (sidebar menu, breadcrumbs,
>adding and editing desks, page titles) all use just "Desks".
>
>This updates the Koha administration page to use "desks" for consistency. It
>also updates the UseCirculationDesks system preference description.
>
>Test plan:
>1. Enable the UseCirculationDesks system preference.
>2. Go to Koha administration > Patrons and circulation
>3. Select the Circulation desks option.
>4. Note that the sidebar menu, breadcrumbs, and page titles all
>   use just "Desks".
>5. Note that in the top-right hand menu bar that it says "NO DESK SET". If
>   you click the dropdown menu it says "Set library and desk".
>6. Apply the patch.
>7. Go to Koha administartion > Patrons and circulation.
>8. Note that the heading now says just "Desks".
>9. Note that the description for the UseCirculationDesks system
>   preference is now "Don't use/Use circulation desks".
>10. Sign off D:
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt     | 2 +-
> .../prog/en/modules/admin/preferences/circulation.pref          | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>index edffefba2b..000f4f0956 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt
>@@ -114,7 +114,7 @@
>                     <dd>Define rules for check-in and checkout notifications for combinations of libraries, patron categories, and item types</dd>
>                 [% END %]
>                 [% IF ( Koha.Preference('UseCirculationDesks') && CAN_user_parameters_manage_libraries ) %]
>-                        <dt><a href="/cgi-bin/koha/admin/desks.pl">Circulation desks</a></dt>
>+                        <dt><a href="/cgi-bin/koha/admin/desks.pl">Desks</a></dt>
>                         <dd>Define circulation desks</dd>
>                 [% END %]
>                 [% IF ( CAN_user_parameters_manage_cities ) %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index e0e0ead489..930476a42d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -169,7 +169,7 @@ Circulation:
>               choices:
>                   1: "Use"
>                   0: "Don't use"
>-            - circulation desks with circulation.
>+            - circulation desks.
> 
>     Checkout policy:
>         -
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35257: 167594 | 167654 | 168089