Attachment 167667 Details for Bug 37005 – Bug 37005: Fix problem with item_type_description being undefined

[patch] Bug 37005: Fix problem with item_type_description being undefined

Bug-37005-Fix-problem-with-itemtypedescription-bei.patch (text/plain), 1.71 KB, created by Matt Blenkinsop on 2024-06-12 14:31:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-06-12 14:31:04 UTC

Size: 1.71 KB

patch

obsolete

>From 3922d2c420b5321db6527fb415bb22b86565f0ec Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Fri, 31 May 2024 21:30:43 +0000
>Subject: [PATCH] Bug 37005: Fix problem with item_type_description being
> undefined
>
>To test:
>1. Set noItemTypeImages to 'Don't show'
>2. Find a record with items and notice the holdings table never loads.
>3. APPLY patch, maybe clear borwser cache too.
>4. Try again, the holdings table should load.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>---
> .../en/includes/html_helpers/tables/items/catalogue_detail.inc  | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 3c08fe3ec7..86e8b3a554 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -351,8 +351,8 @@
>                         node += image_location
>                             ? '<img src="%s" alt="%s" title="%s" /> '.format(escape_str(image_location), escape_str(item_type_description), escape_str(item_type_description))
>                             : '';
>+                        node += '<span class="itypedesc itypetext">%s</span>'.format(escape_str(item_type_description));
>                     [% END %]
>-                    node += '<span class="itypedesc itypetext">%s</span>'.format(escape_str(item_type_description));
>                     return node;
>                 }
>             },
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 37005: 167318 | 167321 | 167667