Attachment 167688 Details for Bug 37016 – Bug 37016: Invalid due date in SIP renew response

[patch] Bug 37016: Invalid due date in SIP renew response

Bug-37016-Invalid-due-date-in-SIP-renew-response.patch (text/plain), 2.03 KB, created by Andreas Jonsson on 2024-06-13 15:05:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andreas Jonsson

Created: 2024-06-13 15:05:45 UTC

Size: 2.03 KB

patch

obsolete

>From 0b8c2e8e3a35f68feaa7ff8ed9361e37d296d613 Mon Sep 17 00:00:00 2001
>From: Andreas Jonsson <andreas.jonsson@kreablo.se>
>Date: Thu, 13 Jun 2024 17:00:31 +0200
>Subject: [PATCH] Bug 37016: Invalid due date in SIP renew response
>
>Test plan using koha-testing-docker:
>
>1) Make sure SIP is running.  You may need to edit
>   /etc/koha/sites/SIPconfig.xml and remove the 8023 connector and
>   restart the SIP-server (koha-sip --restart kohadev)
>2) Find a patron, say 23529000197047
>3) Set a password by selecting "change password", set it to
>   "Password1234"
>4) Find a book, say 39999000000856
>5) Issue book to patron with sip-client:
>   sudo koha-shell -c "/usr/share/koha/bin/sip_cli_emulator.pl \
>                      --address localhost --port 6001 -t cr \
>                      --su term1 --sp term1 --message checkout \
>                      --location CPL --item 39999000000856 \
>                      --patron 23529000197047 --password Password1234"\
>                      kohadev
>6) Note the AH-header in the response which for example:
>   'AH20240619    235900'
>7) Make a renewal with:
>   sudo koha-shell -c "/usr/share/koha/bin/sip_cli_emulator.pl \
>                      --address localhost --port 6001 -t cr \
>                      --su term1 --sp term1 --message renew \
>                      --location CPL --item 39999000000856 \
>                      --patron 23529000197047 --password Password1234"\
>                      kohadev
>8) Make sure the AH-header in the response is different from the
>   response to the checkout, for example: 'AH20240624 235900'
>---
> C4/Circulation.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index b454ff241f..46295ab4d2 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -1590,7 +1590,7 @@ sub AddIssue {
>                       $issuedate,    # here interpreted as the renewal date
>                 }
>             );
>-            $issue = $item_object->checkout;
>+            $issue = $item_object->checkout->get_from_storage;
>         }
>         else {
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37016: 167688 | 167712 | 168152 | 168153