Attachment 167749 Details for Bug 36767 – Bug 36767: Default port should be set to 22

[patch] Bug 36767: Default port should be set to 22

Bug-36767-Default-port-should-be-set-to-22.patch (text/plain), 1.53 KB, created by Matt Blenkinsop on 2024-06-14 16:13:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2024-06-14 16:13:12 UTC

Size: 1.53 KB

patch

obsolete

>From b428ff524b4af852b692cf37399b64c59ae4c426 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Fri, 14 Jun 2024 16:09:54 +0000
>Subject: [PATCH] Bug 36767: Default port should be set to 22
>
>This patch sets a default value for the EDI account form for the upload and download ports
>
>Test plan:
>1) Try to create an EDI account without setting the upload or download ports
>2) The form will crash
>3) Apply patch and restart_all
>4) Try again, the form should submit
>5) In your new EDI account, you should see the value of 22 for both ports
>---
> admin/edi_accounts.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/admin/edi_accounts.pl b/admin/edi_accounts.pl
>index 1c2fb76761..5daa1330cc 100755
>--- a/admin/edi_accounts.pl
>+++ b/admin/edi_accounts.pl
>@@ -79,8 +79,8 @@ else {
>             host               => scalar $input->param('host'),
>             username           => scalar $input->param('username'),
>             password           => $password,
>-            upload_port        => scalar $input->param('upload_port'),
>-            download_port      => scalar $input->param('download_port'),
>+            upload_port        => scalar $input->param('upload_port') || 22,
>+            download_port      => scalar $input->param('download_port') || 22,
>             vendor_id          => scalar $input->param('vendor_id'),
>             upload_directory   => scalar $input->param('upload_directory'),
>             download_directory => scalar $input->param('download_directory'),
>-- 
>2.39.3 (Apple Git-146)

Actions: View | Diff | Splinter Review

Attachments on bug 36767: 167749 | 167750 | 167752 | 167753