Bugzilla – Attachment 167751 Details for
Bug 37089
Cannot delete a fund or a currency
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37089: cud-delete_confirm should not be cud
Bug-37089-cud-deleteconfirm-should-not-be-cud.patch (text/plain), 2.07 KB, created by
Lucas Gass (lukeg)
on 2024-06-14 17:07:53 UTC
(
hide
)
Description:
Bug 37089: cud-delete_confirm should not be cud
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-06-14 17:07:53 UTC
Size:
2.07 KB
patch
obsolete
>From db8b638647b41401df35c7c39166a025a1db91c1 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 14 Jun 2024 10:03:22 -0400 >Subject: [PATCH] Bug 37089: cud-delete_confirm should not be cud > >Adjust aqbudgets.pl and currency.pl to check for the correct op value > >To test: >Part 1 - Delete a fund >1. Go to Acquisitions > Funds >2. Try to delete a fund > --> Confirmation page shows fund name as '' and fund amount as 0.00 >3. Click "Yes, delete this fund" > --> The fund is still there > >Part 2 - Delete a currency >3. Go to Acquisitions > Currencies >4. Try to delete a currency > --> Confirmation shows empty values for currency and rate >5. Click, "Yes, delete this currency" > --> An error message appears and the currency is not deleted > >6. Apply patch and restart_all >7. Repeat steps 1-5 > --> Confirmation pages display correct information, and deletions > occur successfully > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > admin/aqbudgets.pl | 2 +- > admin/currency.pl | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl >index e32b3533a3..6a1df616fc 100755 >--- a/admin/aqbudgets.pl >+++ b/admin/aqbudgets.pl >@@ -185,7 +185,7 @@ if ($op eq 'add_form') { > #---------------------- DEFAULT DISPLAY BELOW --------------------- > > # called by default form, used to confirm deletion of data in DB >-} elsif ($op eq 'cud-delete_confirm') { >+} elsif ($op eq 'delete_confirm') { > > my $budget = GetBudget($budget_id); > $template->param( >diff --git a/admin/currency.pl b/admin/currency.pl >index b706ae0291..6220bbd081 100755 >--- a/admin/currency.pl >+++ b/admin/currency.pl >@@ -91,7 +91,7 @@ if ( $op eq 'add_form' ) { > } > $searchfield = q||; > $op = 'list'; >-} elsif ( $op eq 'cud-delete_confirm' ) { >+} elsif ( $op eq 'delete_confirm' ) { > my $currency = Koha::Acquisition::Currencies->find($currency_code); > > my $nb_of_orders = Koha::Acquisition::Orders->search( { currency => $currency->currency } )->count; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37089
:
167715
|
167717
| 167751