Attachment 167759 Details for Bug 36984 – Bug 36984: Fix "Transit pending from..." message in bibliographic record detail page

[patch] Bug 36984: Fix "Transit pending from..." message in bibliographic record detail page

Bug-36984-Fix-Transit-pending-from-message-in-bibl.patch (text/plain), 2.99 KB, created by Emily Lamancusa (emlam) on 2024-06-14 18:13:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2024-06-14 18:13:33 UTC

Size: 2.99 KB

patch

obsolete

>From 44dba01fa800e2d72aa9c29f7d04e4203a5e9924 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Adolfo=20Rodr=C3=ADguez?= <adolfo.rodriguez@xercode.es>
>Date: Thu, 30 May 2024 12:07:21 +0200
>Subject: [PATCH] Bug 36984: Fix "Transit pending from..." message in
> bibliographic record detail page
>
>Transfering a rotating collection will mark the items contained in the collection as "Transit pending..." and it will trigger a javascript error in the bibliographic record detail page that breaks the holdings table, leaving it caught in the "Processing..." message. This patch fixes that.
>
>The javascript messages gives this error in the console tab:
>Uncaught TypeError: Cannot read properties of undefined (reading 'str')
>
>The error comes from using from_library_ insted of from_library in the file koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>
>Test plan:
>1 Create a rotating collection
>2 Add at least an item to the collection
>3 Transfer the rotating collection
>4 Check the detail page of the bibliography record of any of the items that belong to that collection in the Intranet. Notice that the holdings table gets stuck "Processing..." and that there is a Javascript error
>5 Apply patch, restart services
>6 Repeat step 4. Now the holdings tab works as intended and the item from the collection shows up with the text "Transit pending from..." in the Status column
>7 Sign off
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> .../en/includes/html_helpers/tables/items/catalogue_detail.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 86e8b3a554..10a3cf0614 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -474,7 +474,7 @@
> if ( row.transfer.datesent ) {
> nodes += '%s'.format(_("In transit from %s to %s since %s").format(escape_str(row.transfer._strings.from_library.str), escape_str(row.transfer._strings.to_library.str), $date(row.transfer.datesent)));
> } else {
>- nodes += '%s'.format(_("Transit pending from %s to %s since %s").format(escape_str(row.transfer._strings.from_library_.str), escape_str(row.transfer._strings.to_library.str), $date(row.transfer.daterequested)));
>+ nodes += '%s'.format(_("Transit pending from %s to %s since %s").format(escape_str(row.transfer._strings.from_library.str), escape_str(row.transfer._strings.to_library.str), $date(row.transfer.daterequested)));
> }
> }
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 36984: 167239 | 167269 | 167291 | 167759