Attachment 167810 Details for Bug 37106 – Bug 37106: Fix db revisions 231105009 and 231105010

[patch] Bug 37106: Fix db revisions 231105009 and 231105010

Bug-37106-Fix-db-revisions-231105009-and-231105010.patch (text/plain), 2.72 KB, created by Aleisha Amohia on 2024-06-17 20:53:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2024-06-17 20:53:19 UTC

Size: 2.72 KB

patch

obsolete

>From a20b64607ce7a2a3b89d6d12f08a1f09a27a39bc Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Mon, 17 Jun 2024 20:52:14 +0000
>Subject: [PATCH] Bug 37106: Fix db revisions 231105009 and 231105010
>
>They refer to Koha::Installer::Output methods which aren't available in 23.11.x
>
>This reverts them to the standard `say $out` syntax.
>
>Sponsored-by: Catalyst IT
>---
> installer/data/mysql/db_revs/231105009.pl | 13 ++++---------
> installer/data/mysql/db_revs/231105010.pl |  9 ++-------
> 2 files changed, 6 insertions(+), 16 deletions(-)
>
>diff --git a/installer/data/mysql/db_revs/231105009.pl b/installer/data/mysql/db_revs/231105009.pl
>index c1858761412..37b0e82d2b7 100755
>--- a/installer/data/mysql/db_revs/231105009.pl
>+++ b/installer/data/mysql/db_revs/231105009.pl
>@@ -1,5 +1,4 @@
> use Modern::Perl;
>-use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
> 
> return {
>     bug_number  => "26176",
>@@ -13,19 +12,15 @@ return {
>             UPDATE IGNORE systempreferences SET variable = "StaffLoginRestrictLibraryByIP"
>             WHERE variable = "AutoLocation"
>         }
>-            ) == 1
>-            && say_success( $out, "Renamed system preference 'AutoLocation' to 'StaffLoginRestrictLibraryByIP'" );
>+        );
>+        say $out "Renamed system preference 'AutoLocation' to 'StaffLoginRestrictLibraryByIP'";
> 
>         $dbh->do(
>             q{
>             UPDATE IGNORE systempreferences SET variable = "StaffLoginLibraryBasedOnIP"
>             WHERE variable = "StaffLoginBranchBasedOnIP"
>         }
>-            ) == 1
>-            && say_success(
>-            $out,
>-            "Renamed system preference 'StaffLoginBranchBasedOnIP' to 'StaffLoginLibraryBasedOnIP'"
>-            );
>-
>+        );
>+        say $out "Renamed system preference 'StaffLoginBranchBasedOnIP' to 'StaffLoginLibraryBasedOnIP'";
>     },
> };
>diff --git a/installer/data/mysql/db_revs/231105010.pl b/installer/data/mysql/db_revs/231105010.pl
>index a0e8f231222..09d85b4ecdd 100755
>--- a/installer/data/mysql/db_revs/231105010.pl
>+++ b/installer/data/mysql/db_revs/231105010.pl
>@@ -1,5 +1,4 @@
> use Modern::Perl;
>-use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
> 
> return {
>     bug_number  => "36986",
>@@ -13,11 +12,7 @@ return {
>             UPDATE IGNORE systempreferences SET variable = "StaffLoginLibraryBasedOnIP"
>             WHERE variable = "StaffLoginBranchBasedOnIP"
>         }
>-            ) == 1
>-            && say_success(
>-            $out,
>-            "Renamed system preference 'StaffLoginBranchBasedOnIP' to 'StaffLoginLibraryBasedOnIP'"
>-            );
>-
>+        );
>+        say $out "Renamed system preference 'StaffLoginBranchBasedOnIP' to 'StaffLoginLibraryBasedOnIP'";
>     },
> };
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37106: 167810 | 167814 | 167815