Attachment 167820 Details for Bug 32575 – Bug 32575: Add an empty text body to fix multipart/mixed handling

[patch] Bug 32575: Add an empty text body to fix multipart/mixed handling

Bug-32575-Add-an-empty-text-body-to-fix-multipartm.patch (text/plain), 1.26 KB, created by Magnus Enger on 2024-06-18 09:05:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Magnus Enger

Created: 2024-06-18 09:05:04 UTC

Size: 1.26 KB

patch

obsolete

>From 600052ecb3b9a9f6821a80dcf4f8380be344ef70 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Mon, 17 Jun 2024 02:23:36 +0000
>Subject: [PATCH] Bug 32575: Add an empty text body to fix multipart/mixed
> handling
>
>By adding an empty text body, we force Email::Stuffer/Email::MIME
>to use multipart/mixed handling for the attachment instead of forcing
>a single part (ie direct attachment) email, which is not consistently
>handled by different email clients.
>
>An empty text body is language-neutral (ie not imposing English),
>and it allows SMTP servers to inject organisational footers into
>the email (e.g. confidentiality notices).
>
>Signed-off-by: Magnus Enger <magnus@libriotech.no>
>I have tested this solution in production, and it works for me.
>---
> misc/cronjobs/gather_print_notices.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/misc/cronjobs/gather_print_notices.pl b/misc/cronjobs/gather_print_notices.pl
>index f3d32cb6b8..8360cb3836 100755
>--- a/misc/cronjobs/gather_print_notices.pl
>+++ b/misc/cronjobs/gather_print_notices.pl
>@@ -294,6 +294,7 @@ sub send_files {
>             from    => $from,
>             to      => $to,
>             subject => 'Print notices for ' . $today_syspref,
>+            text_body => ' ',
>         }
>     );
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 32575: 167779 | 167780 | 167781 | 167820 | 167821 | 168225