Bugzilla – Attachment 167839 Details for
Bug 37050
Add select2 to SQL report multi select
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37050: (follow-up) CSS and configuration tweak
Bug-37050-follow-up-CSS-and-configuration-tweak.patch (text/plain), 1.93 KB, created by
Owen Leonard
on 2024-06-18 12:57:28 UTC
(
hide
)
Description:
Bug 37050: (follow-up) CSS and configuration tweak
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-06-18 12:57:28 UTC
Size:
1.93 KB
patch
obsolete
>From 81d758c2d2d26064091ef863c11cbdec7f68bc7d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 18 Jun 2024 12:49:06 +0000 >Subject: [PATCH] Bug 37050: (follow-up) CSS and configuration tweak > >This follow-up tweaks the Select2 CSS so that the selected choices don't >display with 100% width. > >The patch also removes the "closeOnSelect: false" configuration from >Select2. In discussing this option for Bug 36545 more people preferred >the default behavior and I think we should be consistent. >--- > koha-tmpl/intranet-tmpl/prog/css/select2.css | 5 +++++ > .../prog/en/modules/reports/guided_reports_start.tt | 4 +--- > 2 files changed, 6 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/select2.css b/koha-tmpl/intranet-tmpl/prog/css/select2.css >index 8046026ea5..89915eccd3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/select2.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/select2.css >@@ -44,3 +44,8 @@ > .select2-container--default .select2-selection--multiple .select2-selection__choice__remove { > margin-right: 3px; > } >+ >+.select2-container--default .select2-selection--multiple .select2-selection__rendered li { >+ clear: none; >+ width: auto; >+} >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 72a304586e..ece2edb07e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -2320,9 +2320,7 @@ > let selectFields = document.querySelectorAll('select[multiple]'); > selectFields.forEach((selectField) => { > selectField.style.minWidth = '320px'; >- $(selectField).select2({ >- closeOnSelect: false, >- }); >+ $(selectField).select2(); > }); > > }); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37050
:
167555
|
167659
|
167838
|
167839
|
167840
|
167841
|
169750
|
169751
|
169818
|
169819
|
171340
|
171341
|
171342
|
171957
|
171958
|
171959
|
177320
|
179669
|
179728