Bugzilla – Attachment 167894 Details for
Bug 37129
Patron attributes linked to an authorized value don't show a select menu in batch modification
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification
Bug-37129-Patron-attributes-linked-to-an-authorize.patch (text/plain), 1.47 KB, created by
David Nind
on 2024-06-19 19:02:28 UTC
(
hide
)
Description:
Bug 37129: Patron attributes linked to an authorized value don't show a select menu in batch modification
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-06-19 19:02:28 UTC
Size:
1.47 KB
patch
obsolete
>From a602263640971e07c76e22f057c782b57a6a6b16 Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Wed, 19 Jun 2024 10:45:18 -0700 >Subject: [PATCH] Bug 37129: Patron attributes linked to an authorized value > don't show a select menu in batch modification > >Test plan: >1. In Administration - Patron attribute types verify you have the default > SHOW_BCODE using the YES_NO authorized value >2. Tools - Batch patron modification, add a patron card number or > borrowernumber and continue >3. For Patron attribute select Show barcode on the summary screen item > listings, and note that you get a blank text input rather than a select > menu with Yes and No choices >4. Apply patch, restart_all >5. Repeat step 2 and 3, but note that you now get a Yes/No select menu > >Signed-off-by: David Nind <david@davidnind.com> >--- > tools/modborrowers.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl >index efe3a62ff6..502c1e0fa5 100755 >--- a/tools/modborrowers.pl >+++ b/tools/modborrowers.pl >@@ -157,7 +157,7 @@ if ( $op eq 'cud-show' ) { > attribute_code => $attr_type->code, > attribute_lib => $attr_type->description, > category_lib => $category_lib, >- type => $attr_type->authorised_value_category ? 'cud-select' : 'text', >+ type => $attr_type->authorised_value_category ? 'select' : 'text', > }; > } > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37129
:
167885
|
167894
|
167941