Attachment 167942 Details for Bug 37127 – Bug 37127: Authorized value select not working on authority forms

[patch] Bug 37127: Authorized value select not working on authority forms

Bug-37127-Authorized-value-select-not-working-on-a.patch (text/plain), 1.75 KB, created by Emily Lamancusa (emlam) on 2024-06-20 20:43:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2024-06-20 20:43:19 UTC

Size: 1.75 KB

patch

obsolete

>From 8cdd1881ebf43c92a07deee0c5a89c48a2c38fc9 Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Wed, 19 Jun 2024 09:58:18 -0700
>Subject: [PATCH] Bug 37127: Authorized value select not working on authority
> forms
>
>Linking an authority subfield to an authorized value just leaves a blank
>in the form rather than creating a <select>, because there's a stray cud-
>in the type returned from build_authorized_values_list.
>
>Test plan:
> 1. Without the patch, Administration - Authority types - Actions menu for
>    Default - MARC Structure
> 2. Actions menu for 040 - Subfields
> 3. Edit subfields - Tab b - Authorized value - set to LANG - Save changes
> 4. Authorities - New authority - Default
> 5. In 040 tag, click CATALOGING SOURCE to expand the tag
> 6. Note that subfield b has a blank space rather than a dropdown menu
> 7. Apply patch, restart_all
> 8. Authorities - New authority - Default
> 9. In 040 tag, click CATALOGING SOURCE to expand the tag
>10. Note that subfield b has a dropdown menu listing language names
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> authorities/authorities.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/authorities/authorities.pl b/authorities/authorities.pl
>index ac798354f3..761c1f529d 100755
>--- a/authorities/authorities.pl
>+++ b/authorities/authorities.pl
>@@ -84,7 +84,7 @@ sub build_authorized_values_list {
>     }
> 
>     return {
>-        type     => 'cud-select',
>+        type     => 'select',
>         id       => "tag_".$tag."_subfield_".$subfield."_".$index_tag."_".$index_subfield,
>         name     => "tag_".$tag."_subfield_".$subfield."_".$index_tag."_".$index_subfield,
>         values   => \@authorised_values,
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37127: 167884 | 167892 | 167942