Bugzilla – Attachment 167964 Details for
Bug 37091
Cannot delete a local system preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37091: Correct op parameter in systempreferences.pl
Bug-37091-Correct-op-parameter-in-systempreference.patch (text/plain), 1.44 KB, created by
Julian Maurice
on 2024-06-21 13:13:11 UTC
(
hide
)
Description:
Bug 37091: Correct op parameter in systempreferences.pl
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2024-06-21 13:13:11 UTC
Size:
1.44 KB
patch
obsolete
>From d48f70d66d3d5b2f686537f97523625442762761 Mon Sep 17 00:00:00 2001 >From: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Date: Fri, 14 Jun 2024 10:29:34 -0400 >Subject: [PATCH] Bug 37091: Correct op parameter in systempreferences.pl > >To test: >1. Go to Administration > System Preferences > Local Use >2. Attempt to delete a local system preference >--> The confirmation page displays a blank name and value >3. Click "Yes, delete" >--> The system preference is still there >4. Apply patch, restart_all, and reload page >5. Attempt to delete the system preference again >--> The confirmation page displays correct information >6. Click "Yes, delete" >--> The system preference is deleted successfully > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > admin/systempreferences.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/systempreferences.pl b/admin/systempreferences.pl >index 609a06eda4..816714034d 100755 >--- a/admin/systempreferences.pl >+++ b/admin/systempreferences.pl >@@ -339,7 +339,7 @@ if ( $op eq 'add_form' ) { > exit; > ################## DELETE_CONFIRM ################################## > # called by default form, used to confirm deletion of data in DB >-} elsif ( $op eq 'cud-delete_confirm' ) { >+} elsif ( $op eq 'delete_confirm' ) { > my $value = C4::Context->preference($searchfield); > $template->param( > searchfield => $searchfield, >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37091
:
167718
|
167764
| 167964