Bugzilla – Attachment 167977 Details for
Bug 26777
Give the user the option to display their patron card barcode from the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26777: (follow-up) Fix file permssions and tidy
Bug-26777-follow-up-Fix-file-permssions-and-tidy.patch (text/plain), 2.95 KB, created by
Lucas Gass (lukeg)
on 2024-06-21 17:18:44 UTC
(
hide
)
Description:
Bug 26777: (follow-up) Fix file permssions and tidy
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-06-21 17:18:44 UTC
Size:
2.95 KB
patch
obsolete
>From 718efcc432fab4d788d0d4e727ba71a6c146b4e6 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 21 Jun 2024 17:15:57 +0000 >Subject: [PATCH] Bug 26777: (follow-up) Fix file permssions and tidy > >--- > .../data/mysql/atomicupdate/bug_37118.pl | 6 +++-- > opac/opac-virtual-card.pl | 23 +++++++++---------- > 2 files changed, 15 insertions(+), 14 deletions(-) > mode change 100644 => 100755 installer/data/mysql/atomicupdate/bug_37118.pl > mode change 100644 => 100755 opac/opac-virtual-card.pl > >diff --git a/installer/data/mysql/atomicupdate/bug_37118.pl b/installer/data/mysql/atomicupdate/bug_37118.pl >old mode 100644 >new mode 100755 >index 26d3554c94..4c3990c89f >--- a/installer/data/mysql/atomicupdate/bug_37118.pl >+++ b/installer/data/mysql/atomicupdate/bug_37118.pl >@@ -9,10 +9,12 @@ return { > my ( $dbh, $out ) = @$args{qw(dbh out)}; > > # Do you stuffs here >- $dbh->do(q{ >+ $dbh->do( >+ q{ > INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES > ('OPACVirtualCard', '0', NULL,'Enable virtual library cards for patrons on the OPAC.', 'YesNo') >- }); >+ } >+ ); > > # sysprefs > say $out "Added new system preference 'OPACVirtualCard'"; >diff --git a/opac/opac-virtual-card.pl b/opac/opac-virtual-card.pl >old mode 100644 >new mode 100755 >index 423de58dcb..57bab5f493 >--- a/opac/opac-virtual-card.pl >+++ b/opac/opac-virtual-card.pl >@@ -19,39 +19,38 @@ > > use Modern::Perl; > >-use CGI qw ( -utf8 ); >-use C4::Auth qw( get_template_and_user ); >+use CGI qw ( -utf8 ); >+use C4::Auth qw( get_template_and_user ); > use C4::Output qw( output_html_with_http_headers ); > use Koha::Libraries; > use Koha::Patrons; > >- > my $query = CGI->new; > > # if OPACVirtualCard is disabled, leave immediately >-if ( ! C4::Context->preference('OPACVirtualCard') ) { >+if ( !C4::Context->preference('OPACVirtualCard') ) { > print $query->redirect("/cgi-bin/koha/errors/404.pl"); > exit; > } > > my ( $template, $borrowernumber, $cookie ) = get_template_and_user( > { >- template_name => "opac-virtual-card.tt", >- query => $query, >- type => "opac", >+ template_name => "opac-virtual-card.tt", >+ query => $query, >+ type => "opac", > } > ); > >-my $patron = Koha::Patrons->find( $borrowernumber ); >+my $patron = Koha::Patrons->find($borrowernumber); >+ > # Find and display patron image if allowed >-if (C4::Context->preference('OPACpatronimages')) { >- $template->param( display_patron_image => 1 ) if $patron->image; >- } >+if ( C4::Context->preference('OPACpatronimages') ) { >+ $template->param( display_patron_image => 1 ) if $patron->image; >+} > > $template->param( > virtualcardview => 1, > patron => $patron, > ); > >- > output_html_with_http_headers $query, $cookie, $template->output, undef, { force_no_caching => 1 }; >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26777
:
167969
|
167970
|
167971
|
167972
|
167976
|
167977
|
168029
|
168030
|
168165
|
168166
|
168167
|
168168
|
168169
|
168170
|
168171
|
168172
|
168289
|
168290
|
168291
|
168292
|
168293
|
168294
|
168295
|
168296
|
169742
|
169743
|
169744
|
169745
|
169746
|
169747
|
169748
|
169749
|
170667
|
170668
|
170669
|
170670
|
170671
|
170672
|
170673
|
170674