Attachment 167993 Details for Bug 37152 – Bug 37152: Can't delete an Acquisitions contract

[patch] Bug 37152: Can't delete an Acquisitions contract

Bug-37152-Cant-delete-an-Acquisitions-contract.patch (text/plain), 1.60 KB, created by Emily Lamancusa (emlam) on 2024-06-21 20:25:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Emily Lamancusa (emlam)

Created: 2024-06-21 20:25:59 UTC

Size: 1.60 KB

patch

obsolete

>From 5842613ad5544a34043613789d3d6834ced1f295 Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Fri, 21 Jun 2024 11:38:10 -0700
>Subject: [PATCH] Bug 37152: Can't delete an Acquisitions contract
>
>admin/aqcontract.pl expects the op cud-delete-confirm, but what's sent is
>the op delete-confirm because it's just a GET of the page that will actually
>do a cud op once it is confirmed.
>
>Test plan:
>1. Without the patch, Acquisitions - Vendor search for My Vendor
>2. Left Sidebar menu - Contracts - Add a contract
>3. Fill in Name, Start date, End date, Save
>4. On the line for the contract, click Delete
>5. Note that the page that loads has no button for "Yes, delete contract"
>   (or for anything else)
>6. Apply patch, restart_all
>7. Acquisitions - Vendor search for My Vendor
>8. Left Sidebar menu, Contracts, click Delete, then Yes, delete contract
>9. Vendor search for My Vendor, Left Sidebar Contracts, verify the contract
>   is gone
>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>---
> admin/aqcontract.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/admin/aqcontract.pl b/admin/aqcontract.pl
>index 46954ea026..c1bca4a4c5 100755
>--- a/admin/aqcontract.pl
>+++ b/admin/aqcontract.pl
>@@ -129,7 +129,7 @@ elsif ( $op eq 'cud-add_validate' ) {
>     # END $OP eq ADD_VALIDATE
> }
> #DELETE_CONFIRM: called by default form, used to confirm deletion of data in DB
>-elsif ( $op eq 'cud-delete_confirm' ) {
>+elsif ( $op eq 'delete_confirm' ) {
>     $template->param( delete_confirm => 1 );
> 
>     my $contract = GetContract( { contractnumber => $contractnumber } );
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37152: 167987 | 167988 | 167989 | 167990 | 167993 | 167994 | 167995 | 167996 | 168104 | 168105 | 168106 | 168107