Bugzilla – Attachment 167998 Details for
Bug 36557
Improve logic and display of OPAC cart, tag, and lists controls
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36557: (follow-up) Restore missing "Remove from list" control
Bug-36557-follow-up-Restore-missing-Remove-from-li.patch (text/plain), 2.90 KB, created by
David Nind
on 2024-06-21 23:21:41 UTC
(
hide
)
Description:
Bug 36557: (follow-up) Restore missing "Remove from list" control
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-06-21 23:21:41 UTC
Size:
2.90 KB
patch
obsolete
>From 32e02e344b8b6e208f605e186acf306a83ea2c6a Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 21 Jun 2024 15:10:05 +0000 >Subject: [PATCH] Bug 36557: (follow-up) Restore missing "Remove from list" > control > >This patch restores the "Remove from list" control to the batch >operations toolbar when one is looking at the contents of a list. It was >unintentionally left out of the previous patch. > >The patch also corrects some button markup to ensure consisten style of >controls in the batch operations toolbar. > >Signed-off-by: David Nind <david@davidnind.com> >--- > .../bootstrap/en/includes/result-batch-controls.inc | 10 +++++++++- > .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 3 +-- > 2 files changed, 10 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/result-batch-controls.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/result-batch-controls.inc >index eed84b5736..8e9e7d5bbe 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/result-batch-controls.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/result-batch-controls.inc >@@ -23,7 +23,9 @@ > > [% IF ( CartEnabled ) %] > <div class="btn-group"> >- <a id="addtocart" class="btn btn-link btn-xs" href="#"><i class="fa fa-shopping-cart" aria-hidden="true"></i> Add to cart</a> >+ <button id="addtocart" class="btn btn-link btn-xs"> >+ <i class="fa fa-shopping-cart" aria-hidden="true"></i> Add to cart >+ </button> > </div> > [% END %] > >@@ -62,6 +64,12 @@ > <a href="#" class="dropdown-item addtolist newlist">New list</a> > </div> > </div> >+ [% IF loggedinusername && can_remove_biblios %] >+ <button class="btn btn-link btn-sm disabled removeitems tag_hides"> >+ <i class="fa fa-fw fa-remove" aria-hidden="true"></i> Remove from list</button> >+ </button> >+ [% END %] >+ > [% END # /IF virtualshelves %] > > [% IF ( MultiHolds ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index 49ad1d7392..81ef824034 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -959,9 +959,8 @@ $(function() { > selected_titles.prop("checked", false ); > } > }); >- >- $("#removeitems").html("<a href=\"#\" class=\"btn btn-link disabled removeitems tag_hides\"><i class=\"fa fa-fw fa-remove\" aria-hidden=\"true\"></i> "+_("Remove from list")+"</a>"); > [% END %] >+ > [% IF OpenLibraryCovers %]KOHA.OpenLibrary.GetCoverFromIsbn();[% END %] > [% IF OPACLocalCoverImages %]KOHA.LocalCover.GetCoverFromBibnumber(false);[% END %] > [% IF ( GoogleJackets ) %]KOHA.Google.GetCoverFromIsbn();[% END %] >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36557
:
164563
|
166297
|
166422
|
166798
|
167966
|
167997
|
167998
|
168248
|
168249
|
168251
|
168252