Bugzilla – Attachment 168006 Details for
Bug 37165
Can't edit frequencies due to stray cud- in modify op
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37165: Can't edit frequencies due to stray cud- in modify op
Bug-37165-Cant-edit-frequencies-due-to-stray-cud--.patch (text/plain), 1.54 KB, created by
Phil Ringnalda
on 2024-06-22 23:47:36 UTC
(
hide
)
Description:
Bug 37165: Can't edit frequencies due to stray cud- in modify op
Filename:
MIME Type:
Creator:
Phil Ringnalda
Created:
2024-06-22 23:47:36 UTC
Size:
1.54 KB
patch
obsolete
>From 2b0956dd2c82443aba009d82c185df9ed47b7b32 Mon Sep 17 00:00:00 2001 >From: Phil Ringnalda <phil@chetcolibrary.org> >Date: Sat, 22 Jun 2024 16:40:19 -0700 >Subject: [PATCH] Bug 37165: Can't edit frequencies due to stray cud- in modify > op > >The op modify in subscription-frequencies.pl isn't a cud- operation, it's >a GET of the editing form, so it shouldn't have been changed to cud-modify. > >Test plan: >1. Don't apply the patch yet >2. Serials - Manage frequencies - for any frequency click Edit >2. Note that the editing form is empty >3. Apply patch, restart_all >4. Repeat step 2, note that now the editing form has the existing data >5. Change anything, Display order is nice, and save to verify that > cud-savemod still works >--- > serials/subscription-frequencies.pl | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/serials/subscription-frequencies.pl b/serials/subscription-frequencies.pl >index 138fd66878..77fa4c268b 100755 >--- a/serials/subscription-frequencies.pl >+++ b/serials/subscription-frequencies.pl >@@ -46,11 +46,11 @@ my ($template, $loggedinuser, $cookie, $flags) = get_template_and_user( { > > my $op = $input->param('op'); > >-if($op && ($op eq 'new' || $op eq 'cud-modify')) { >+if($op && ($op eq 'new' || $op eq 'modify')) { > my @units_loop; > push @units_loop, {val => $_} for (qw/ day week month year /); > >- if($op eq 'cud-modify') { >+ if($op eq 'modify') { > my $frequencyid = $input->param('frequencyid'); > my $frequency = GetSubscriptionFrequency($frequencyid); > foreach (@units_loop) { >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37165
:
168006
|
168026
|
168111