Bugzilla – Attachment 168060 Details for
Bug 35197
Expose additional_field definitions through REST API
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35197: (QA follow-up): Update tablename
Bug-35197-QA-follow-up-Update-tablename.patch (text/plain), 2.23 KB, created by
Martin Renvoize (ashimema)
on 2024-06-25 12:08:28 UTC
(
hide
)
Description:
Bug 35197: (QA follow-up): Update tablename
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-06-25 12:08:28 UTC
Size:
2.23 KB
patch
obsolete
>From 14791caa4647b365fa592efe58f8d615b04d4137 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Mon, 29 Apr 2024 10:00:42 +0000 >Subject: [PATCH] Bug 35197: (QA follow-up): Update tablename > >prove t/db_dependent/api/v1/additional_fields.t > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > Koha/REST/V1/AdditionalFields.pm | 2 +- > api/v1/swagger/paths/additional_fields.yaml | 2 +- > t/db_dependent/api/v1/additional_fields.t | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Koha/REST/V1/AdditionalFields.pm b/Koha/REST/V1/AdditionalFields.pm >index db9e2ed8d22..21f4b899d54 100644 >--- a/Koha/REST/V1/AdditionalFields.pm >+++ b/Koha/REST/V1/AdditionalFields.pm >@@ -34,7 +34,7 @@ use Try::Tiny qw( catch try ); > sub list { > my $c = shift->openapi->valid_input or return; > >- my $tablename = $c->param('tablename'); >+ my $tablename = $c->param('table_name'); > > return try { > my $additional_fields_set = Koha::AdditionalFields->new; >diff --git a/api/v1/swagger/paths/additional_fields.yaml b/api/v1/swagger/paths/additional_fields.yaml >index 3f5b5b651fe..887dba81b9d 100644 >--- a/api/v1/swagger/paths/additional_fields.yaml >+++ b/api/v1/swagger/paths/additional_fields.yaml >@@ -11,7 +11,7 @@ > parameters: > - description: filter by table name > in: query >- name: tablename >+ name: table_name > type: string > - $ref: "../swagger.yaml#/parameters/match" > - $ref: "../swagger.yaml#/parameters/order_by" >diff --git a/t/db_dependent/api/v1/additional_fields.t b/t/db_dependent/api/v1/additional_fields.t >index 6c0a9fdb5a2..29b7c4e30e2 100755 >--- a/t/db_dependent/api/v1/additional_fields.t >+++ b/t/db_dependent/api/v1/additional_fields.t >@@ -99,7 +99,7 @@ subtest 'list() tests' => sub { > ); > > # Filtering works, two agreements sharing vendor_id >- $t->get_ok( "//$userid:$password@/api/v1/additional_fields?tablename=" . $additional_field->tablename ) >+ $t->get_ok( "//$userid:$password@/api/v1/additional_fields?table_name=" . $additional_field->tablename ) > ->status_is(200)->json_is( [ $additional_field->to_api, $another_additional_field->to_api ] ); > > # Warn on unsupported query parameter >-- >2.45.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35197
:
158112
|
158511
|
158512
|
158514
|
158515
|
158577
|
158578
|
159648
|
159649
|
159650
|
165726
|
165727
|
165728
|
165769
|
165780
|
168057
|
168058
|
168059
| 168060 |
168061
|
168062
|
168063
|
168064
|
168065