Attachment 168068 Details for Bug 37078 – Bug 37078: Damaged status not showing in detail.pl

[patch] Bug 37078: Damaged status not showing in detail.pl

Bug-37078-Damaged-status-not-showing-in-detailpl.patch (text/plain), 2.77 KB, created by Lucas Gass (lukeg) on 2024-06-25 13:42:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-06-25 13:42:28 UTC

Size: 2.77 KB

patch

obsolete

>From 77a11ba4af088f9eca64681099074ff0575bc417 Mon Sep 17 00:00:00 2001
>From: Phil Ringnalda <phil@chetcolibrary.org>
>Date: Sat, 22 Jun 2024 11:58:41 -0700
>Subject: [PATCH] Bug 37078: Damaged status not showing in detail.pl
>
>The API returns the fact that an item is damaged in 'damaged_status' but the
>code that builds the holdings table is looking for 'damaged' so it doesn't
>find that an item is damaged.
>
>Test plan:
>1. Administration - Authorized values - DAMAGED row, click Add
>2. Give it the Authorized value 2 and the Description Awful
>3. On a record with more than one item, like Empress of the blues,
> edit one item to have Damaged status: Damaged and one to have
> Damaged status: Awful
>4. On the bib detail view, note that the status column shows both
> as 'Available'
>5. Apply patch, refresh
>6. Note that now one shows as Damaged and one as Awful (verifying that
> the value is being read from the AV, not the fallback default which
> is also 'Damaged')
>
>Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../includes/html_helpers/tables/items/catalogue_detail.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 86e8b3a554..3566d4b043 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -488,8 +488,8 @@
> nodes += '%s'.format(escape_str(withdrawn_lib));
> }
> 
>- if ( row.damaged ) {
>- let damaged_lib = av_damaged.get(row.damaged.toString()) || _("Damaged");
>+ if ( row.damaged_status ) {
>+ let damaged_lib = av_damaged.get(row.damaged_status.toString()) || _("Damaged");
> nodes += '%s'.format(escape_str(damaged_lib));
> }
> 
>@@ -533,7 +533,7 @@
> }
> [% END %]
> 
>- if ( ! ( row.not_for_loan_status || item_types_notforloan[row.item_type_id] || row.checked_out_date || row.lost_status || row.withdrawn || row.damaged || row.transfer || row.first_hold || row.recall ) ) {
>+ if ( ! ( row.not_for_loan_status || item_types_notforloan[row.item_type_id] || row.checked_out_date || row.lost_status || row.withdrawn || row.damaged_status || row.transfer || row.first_hold || row.recall ) ) {
> nodes += ' %s'.format(_("Available"))
> }
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37078: 168003 | 168021 | 168068