Attachment 168073 Details for Bug 33317 – Bug 33317: Using checkoxes in OpacMetaRobots preference system to prevent incorrect data entry

[patch] Bug 33317: Using checkoxes in OpacMetaRobots preference system to prevent incorrect data entry

Bug-33317-Using-checkoxes-in-OpacMetaRobots-prefer.patch (text/plain), 3.38 KB, created by Lucas Gass (lukeg) on 2024-06-25 14:22:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-06-25 14:22:22 UTC

Size: 3.38 KB

patch

obsolete

>From 8b07ce10d570d9dc0796bdbd39200977bd9e341a Mon Sep 17 00:00:00 2001
>From: Hammat Wele <hammat.wele@inlibro.com>
>Date: Fri, 10 Nov 2023 19:48:21 +0000
>Subject: [PATCH] Bug 33317: Using checkoxes in OpacMetaRobots preference
> system to prevent incorrect data entry
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> installer/data/mysql/atomicupdate/bug_33317.pl                | 2 +-
> installer/data/mysql/mandatory/sysprefs.sql                   | 2 +-
> .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref | 4 +++-
> 3 files changed, 5 insertions(+), 3 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_33317.pl b/installer/data/mysql/atomicupdate/bug_33317.pl
>index edffff480d..58858e4e27 100644
>--- a/installer/data/mysql/atomicupdate/bug_33317.pl
>+++ b/installer/data/mysql/atomicupdate/bug_33317.pl
>@@ -7,7 +7,7 @@ return {
>         my ($args) = @_;
>         my ($dbh, $out) = @$args{qw(dbh out)};
> 
>-        $dbh->do(q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('OpacMetaRobots','','','Improve search engine crawling.', 'Textarea') });
>+        $dbh->do(q{INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type) VALUES ('OpacMetaRobots','','','Improve search engine crawling.', 'Multiple') });
> 
>         say $out "Added system preference 'OpacMetaRobots'";
>     },
>diff --git a/installer/data/mysql/mandatory/sysprefs.sql b/installer/data/mysql/mandatory/sysprefs.sql
>index 7a44bc4c6e..56e4eeb2a4 100644
>--- a/installer/data/mysql/mandatory/sysprefs.sql
>+++ b/installer/data/mysql/mandatory/sysprefs.sql
>@@ -510,7 +510,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('OPACMandatoryHoldDates', '', '|start|end|both', 'Define which hold dates are required on OPAC reserve form', 'Choice'),
> ('OpacMaxItemsToDisplay','50','','Max items to display at the OPAC on a biblio detail','Integer'),
> ('OpacMetaDescription','','','This description will show in search engine results (160 characters).','Textarea'),
>-('OpacMetaRobots','','','Improve search engine crawling.','Textarea'),
>+('OpacMetaRobots', 'noindex,nofollow', NULL, 'Improve search engine crawling.', 'Multiple'),
> ('OPACMySummaryHTML','','70|10','Enter the HTML that will appear in a column on the \'my summary\' and \'my checkout history\' tabs when a user is logged in to the OPAC. Enter {BIBLIONUMBER}, {TITLE}, {AUTHOR}, or {ISBN} in place of their respective variables in the HTML. Leave blank to disable.','Textarea'),
> ('OpacNewsLibrarySelect','0','','Show selector for branches on OPAC news page','YesNo'),
> ('OpacNoItemTypeImages','0',NULL,'If ON, disables itemtype images in the OPAC','YesNo'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 3dd91612ec..e667d9aa05 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -63,7 +63,9 @@ OPAC:
>         -
>             - "Improve search engine crawling."
>             - pref: OpacMetaRobots
>-              type: textarea
>+              multiple:
>+               noindex: "noindex"
>+               nofollow: "nofollow"
>         -
>             - By default, show bibliographic records
>             - pref: BiblioDefaultView
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 33317: 148575 | 148593 | 150420 | 158820 | 159653 | 160125 | 160126 | 160534 | 160539 | 160540 | 160541 | 160544 | 160545 | 160546 | 168071 | 168072 | 168073 | 168074 | 168075