Bugzilla – Attachment 168102 Details for
Bug 37190
form-submit.js data- attributes should use lowercase attribute names
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37190: HTML data attributes are always lowercase
Bug-37190-HTML-data-attributes-are-always-lowercas.patch (text/plain), 1.22 KB, created by
Lucas Gass (lukeg)
on 2024-06-25 21:38:02 UTC
(
hide
)
Description:
Bug 37190: HTML data attributes are always lowercase
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-06-25 21:38:02 UTC
Size:
1.22 KB
patch
obsolete
>From 3977afc20a8bfe32d3b98a968d0baf6438e831f4 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 25 Jun 2024 21:36:35 +0000 >Subject: [PATCH] Bug 37190: HTML data attributes are always lowercase > >Test plan: >1. I don't really know how to write a good test plan for this one. >2. Review the changes, see if you agree. >--- > koha-tmpl/intranet-tmpl/prog/js/form-submit.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/form-submit.js b/koha-tmpl/intranet-tmpl/prog/js/form-submit.js >index d7b8222cbe..b5176ef985 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/form-submit.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/form-submit.js >@@ -4,13 +4,13 @@ $(document).ready(function () { > e.preventDefault(); > let form_data = $(this).data(); > >- let confirm_msg = form_data.confirmationMsg; >+ let confirm_msg = form_data.confirmationmsg; > if (confirm_msg) { > let confirmation = confirm(confirm_msg); > if (!confirmation) { > return false; > } >- delete form_data.confirmationMsg; >+ delete form_data.confirmationmsg; > } > > let the_form = $("<form/>"); >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37190
: 168102