Attachment 168140 Details for Bug 36741 – Bug 36741: Skip auto_too_soon issues in auto renew digest

[patch] Bug 36741: Skip auto_too_soon issues in auto renew digest

Bug-36741-Skip-autotoosoon-issues-in-auto-renew-di.patch (text/plain), 1.61 KB, created by Lucas Gass (lukeg) on 2024-06-26 13:04:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-06-26 13:04:16 UTC

Size: 1.61 KB

patch

obsolete

>From e3bdacb4bd2eb371a76a039b0797cf216da2a596 Mon Sep 17 00:00:00 2001
>From: David Cook <dcook@prosentient.com.au>
>Date: Thu, 23 May 2024 00:47:08 +0000
>Subject: [PATCH] Bug 36741: Skip auto_too_soon issues in auto renew digest
>
>This change adds a line to skip auto_too_soon issues/checkouts
>in the auto renew digest template.
>
>Since auto_too_soon do not trigger notifications and don't require
>any special action, let's skip them in the breakdown of checkouts in
>the AUTO_RENEWALS_DGST email.
>
>Test plan:
>0. Apply the patch
>1. reset_all (in koha-testing-docker)
>2. Note the following line in the AUTO_RENEWALS_DGST template:
>[% NEXT IF (checkout.auto_renew_error == 'auto_too_soon') %]
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> installer/data/mysql/en/mandatory/sample_notices.yml | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/installer/data/mysql/en/mandatory/sample_notices.yml b/installer/data/mysql/en/mandatory/sample_notices.yml
>index 7e411b9227..0cb966a78a 100644
>--- a/installer/data/mysql/en/mandatory/sample_notices.yml
>+++ b/installer/data/mysql/en/mandatory/sample_notices.yml
>@@ -2222,6 +2222,7 @@ tables:
>             - "There were [% success %] items that were renewed."
>             - "[% END %]"
>             - "[% FOREACH checkout IN checkouts %]"
>+            - "[% NEXT IF (checkout.auto_renew_error == 'auto_too_soon') %]"
>             - "[% checkout.item.biblio.title %] : [% checkout.item.barcode %]"
>             - "[% IF !checkout.auto_renew_error %]"
>             - "was renewed until [% checkout.date_due | $KohaDates as_due_date => 1%]"
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 36741: 167054 | 167137 | 168140