Attachment 168173 Details for Bug 35240 – Bug 35240: Add missing IDs to input

[patch] Bug 35240: Add missing IDs to input

Bug-35240-Add-missing-IDs-to-input.patch (text/plain), 2.80 KB, created by Nick Clemens (kidclamp) on 2024-06-26 17:47:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-06-26 17:47:10 UTC

Size: 2.80 KB

patch

obsolete

>From 407efb42507d5c29c76d443f2107118073d5729a Mon Sep 17 00:00:00 2001
>From: Eric Garcia <cubingguy714@gmail.com>
>Date: Tue, 25 Jun 2024 17:18:13 +0000
>Subject: [PATCH] Bug 35240: Add missing IDs to input
>
>1. Tools -> Rotating collections -> Edit collection
>2. Use browser dev tools to notice that the inputs don't have matching
>   IDs
>3. Apply patch
>4. Do step 2 again and notice IDs are no longer missing.
>5. Sign off :)
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> .../en/modules/rotating_collections/editCollections.tt    | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt
>index f687e9bc2f8..7edfcbdec36 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/editCollections.tt
>@@ -137,19 +137,19 @@
>                                 <li>
>                                     <label class="required" for="title">Title: </label>
>                                     [% IF ( editColTitle ) %]
>-                                        <input type="text" name="title" value="[% editColTitle | html %]" required="required" />
>+                                        <input id="title" type="text" name="title" value="[% editColTitle | html %]" required="required" />
>                                         <span class="required">Required</span>
>                                     [% ELSE %]
>-                                        <input type="text" name="title" required="required" />
>+                                        <input id="title" type="text" name="title" required="required" />
>                                         <span class="required">Required</span>
>                                     [% END %]
>                                 </li>
>                                 <li>
>                                     <label for="description">Description: </label>
>                                     [% IF (editColDescription ) %]
>-                                        <input type="text" size="50" name="description" value="[% editColDescription | html %]" />
>+                                        <input id="description" type="text" size="50" name="description" value="[% editColDescription | html %]" />
>                                     [% ELSE %]
>-                                        <input type="text" size="50" name="description" />
>+                                        <input id="description" type="text" size="50" name="description" />
>                                     [% END %]
>                                 </li>
>                             </ol>
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 35240: 168087 | 168147 | 168173