Bugzilla – Attachment 16818 Details for
Bug 9877
Use DataTables on funds administration page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 9877 - Use DataTables on funds administration page
SIGNED-OFF-Bug-9877---Use-DataTables-on-funds-admi.patch (text/plain), 3.52 KB, created by
Owen Leonard
on 2013-03-22 18:47:32 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 9877 - Use DataTables on funds administration page
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2013-03-22 18:47:32 UTC
Size:
3.52 KB
patch
obsolete
>From 49c68829c2ceb203ebd3a899b39c6e6e626a532d Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 20 Mar 2013 15:16:59 -0400 >Subject: [PATCH] [SIGNED-OFF] Bug 9877 - Use DataTables on funds > administration page >Content-Type: text/plain; charset="utf-8" > >Replace the tablesorter plugin with the DataTables plugin on the funds >administration page. > >To test, open the funds administration page (Administration -> >Funds). Confirm that table sorting, paging, and searching works >correctly. > >Note that the table is sorted only when hierarchical display of parent >and child funds is not enabled. When the hierarchicial display is >enabled the table sorter is not triggered. > >Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> > >Post-QA revision adds handling for empty table: "No funds" row must have >same number of cells as the rest of the table (including hidden cell); >--- > .../prog/en/modules/admin/aqbudgets.tt | 27 +++++++++++++------- > 1 file changed, 18 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt >index af0f086..6bd3606 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt >@@ -136,10 +136,16 @@ > //]]> > </script> > [% ELSE %] >-<link href="[% themelang %]/lib/jquery/plugins/treetable/stylesheets/jquery.treeTable.css" rel="stylesheet" type="text/css" /> >+ [% IF ( notree ) %] >+ <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> >+ <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.dataTables.min.js"></script> >+ [% INCLUDE 'datatables-strings.inc' %] >+ <script type="text/javascript" src="[% themelang %]/js/datatables.js"></script> >+ [% ELSE %] >+ <link href="[% themelang %]/lib/jquery/plugins/treetable/stylesheets/jquery.treeTable.css" rel="stylesheet" type="text/css" /> >+ <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/treetable/jquery.treeTable.min.js"></script> >+ [% END %] > >-<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.tablesorter.min.js"></script> >-<script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/treetable/jquery.treeTable.min.js"></script> > <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.qtip.js"></script> > > <script type="text/javascript"> >@@ -174,11 +180,14 @@ > } > }); > [% IF ( notree ) %] >- $("#budgeth").tablesorter({ >- widgets : ['zebra'], >- sortList: [[0,0]], >- headers: { 7: { sorter: false }} >- }); >+ $("#budgeth").dataTable($.extend(true, {}, dataTablesDefaults, { >+ "aoColumnDefs": [ >+ { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false }, >+ ], >+ "aLengthMenu": [[10, 20, 50, 100, -1], [10, 20, 50, 100, "All"]], >+ "iDisplayLength": 20, >+ "sPaginationType": "four_button" >+ })); > [% ELSE %] > $("#budgeth").treeTable(); > [% END %] >@@ -296,7 +305,7 @@ > </tr> > [% END %] > [% ELSE %] >- <tr><td colspan="12">No fund found</td></tr> >+ <tr><td>No fund found</td><td> </td><td> </td><td> </td><td> </td><td> </td><td> </td><td class="tooltipcontent"> </td><td> </td></tr> > [% END %] > </tbody> > </table> >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9877
:
16557
|
16575
|
16581
|
16582
|
16818
|
16936
|
17148
|
17155
|
17156