Bugzilla – Attachment 168188 Details for
Bug 36128
Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Overdues.pm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36128: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Overdues.pm
Bug-36128-Use-of-uninitialized-value-in-string-eq-.patch (text/plain), 1.57 KB, created by
Martin Renvoize (ashimema)
on 2024-06-27 09:02:48 UTC
(
hide
)
Description:
Bug 36128: Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Overdues.pm
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-06-27 09:02:48 UTC
Size:
1.57 KB
patch
obsolete
>From 1dad665a6e527e2ce0cdc851390910b6ecc4ee43 Mon Sep 17 00:00:00 2001 >From: Denys Konovalov <kontakt@denyskon.de> >Date: Sun, 23 Jun 2024 14:13:35 +0200 >Subject: [PATCH] Bug 36128: Use of uninitialized value in string eq at > /usr/share/koha/lib/C4/Overdues.pm > >Fixes the following error message when running the overdues check cronjob on a >Koha system without defined overdue rules: > >/etc/cron.daily/koha-common: >Use of uninitialized value in string eq at /usr/share/koha/lib/C4/Overdues.pm >line 686. > >by checking if the variable is defined before comparing it. > >Test plan: >1. Go to Tools - Overdue notice/status triggers and verify that for every single > patron type for both Default and every individual library, you have no value > set for Delay, so that you will never send anyone an overdue notice >2. Run the cron job which creates and sends overdue notices >3. Confirm the above mentioned error no longer appears > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > C4/Overdues.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Overdues.pm b/C4/Overdues.pm >index 41674a468a1..a2494f7f1e9 100644 >--- a/C4/Overdues.pm >+++ b/C4/Overdues.pm >@@ -683,7 +683,7 @@ sub GetBranchcodesWithOverdueRules { > WHERE delay1 IS NOT NULL > ORDER BY branchcode > |); >- if ( $branchcodes->[0] eq '' ) { >+ if ( defined $branchcodes->[0] && $branchcodes->[0] eq '' ) { > # If a default rule exists, all branches should be returned > return Koha::Libraries->search({}, { order_by => 'branchname' })->get_column('branchcode'); > } >-- >2.45.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36128
:
168008
| 168188 |
168189