Attachment 168220 Details for Bug 37038 – Bug 37038: koha-elasticsearch creates a file named 0

[patch] Bug 37038: koha-elasticsearch creates a file named 0

Bug-37038-koha-elasticsearch-creates-a-file-named-.patch (text/plain), 1.70 KB, created by Marcel de Rooy on 2024-06-28 06:33:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-06-28 06:33:12 UTC

Size: 1.70 KB

patch

obsolete

>From 01b32c408a14429f86015839a6d36263060970d0 Mon Sep 17 00:00:00 2001
>From: Janusz Kaczmarek <januszop@gmail.com>
>Date: Wed, 5 Jun 2024 17:27:03 +0000
>Subject: [PATCH] Bug 37038: koha-elasticsearch creates a file named 0
>Content-Type: text/plain; charset=utf-8
>
>After execution of koha-elasticsearch command a file named 0 remains in
>the current directory.
>
>Inside the single parentheses, the character '>' is treated as a file
>redirection, not as a comparison operator.
>
>Test plan:
>==========
>1. Have a test installation with Elasticsearch.  As root, perform:
>   ./debian/scripts/koha-elasticsearch --rebuild kohadev
>   When the command finishes, check the contents of the current
>   directory (ls -ltr | tail).  You sould notice a fresh file named '0'
>2. Apply the patch. Delete the file named 0.
>3. Repeat p. 1.  There should be no file named 0 now.
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> debian/scripts/koha-elasticsearch | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/debian/scripts/koha-elasticsearch b/debian/scripts/koha-elasticsearch
>index a5428175ac..24f4970941 100755
>--- a/debian/scripts/koha-elasticsearch
>+++ b/debian/scripts/koha-elasticsearch
>@@ -90,12 +90,12 @@ run_rebuild_elasticsearch()
>         KOHA_BINDIR=${KOHA_HOME}/misc
>     fi
> 
>-    if [ "${clo_commit_size}" > 0 ]; then
>+    if [ "${clo_commit_size}" \> 0 ]; then
>         commit_size=${clo_commit_size}
>     fi
>     rebuild_opts="--commit ${commit_size}"
> 
>-    if [ "${clo_processes}" > 0 ]; then
>+    if [ "${clo_processes}" \> 0 ]; then
>         processes=${clo_processes}
>     fi
>     rebuild_opts="${rebuild_opts} --processes ${processes}"
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 37038: 167487 | 167491 | 168220 | 168221 | 168222